From cd078fac33b60e753886ded2e821ef765a137110 Mon Sep 17 00:00:00 2001 From: Iuliana Prodan Date: Fri, 21 Aug 2020 17:30:58 +0300 Subject: [PATCH] MLK-24517-1 crypto: caam - removed unnecessary validation of black key for blob decapsulation The address of an array is never NULL, so the comparison of black key array always evaluate the same way. Remove unnecessary check. Reported-by: Coverity 10893156 Signed-off-by: Iuliana Prodan Reviewed-by: Franck LENORMAND --- drivers/crypto/caam/caamkeyblob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/caam/caamkeyblob.c b/drivers/crypto/caam/caamkeyblob.c index a71604c466bc..16841dd68ea5 100644 --- a/drivers/crypto/caam/caamkeyblob.c +++ b/drivers/crypto/caam/caamkeyblob.c @@ -531,7 +531,7 @@ int caam_blob_decap(struct device *dev, struct keyblob_info *info) trusted_key = (info->type >> TAG_OBJ_TK_OFFSET) & 0x1; /* Validate input data*/ - if (!info->black_key || !info->key_mod || !blob) + if (!info->key_mod || !blob) return -EINVAL; dev_dbg(dev, "%s input: [blob: %p (%zu), mem_type: %x, color: %x",