iMX/i2som-imx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
02228658df7d84d384ea622d848920da170281da
i2som-imx-linux/net/netfilter
History
Florian Westphal b0e56e3c56 netfilter: nat: can't use dst_hold on noref dst 
[ Upstream commit 542fbda0f0 ]

The dst entry might already have a zero refcount, waiting on rcu list
to be free'd.  Using dst_hold() transitions its reference count to 1, and
next dst release will try to free it again -- resulting in a double free:

  WARNING: CPU: 1 PID: 0 at include/net/dst.h:239 nf_xfrm_me_harder+0xe7/0x130 [nf_nat]
  RIP: 0010:nf_xfrm_me_harder+0xe7/0x130 [nf_nat]
  Code: 48 8b 5c 24 60 65 48 33 1c 25 28 00 00 00 75 53 48 83 c4 68 5b 5d 41 5c c3 85 c0 74 0d 8d 48 01 f0 0f b1 0a 74 86 85 c0 75 f3 <0f> 0b e9 7b ff ff ff 29 c6 31 d2 b9 20 00 48 00 4c 89 e7 e8 31 27
  Call Trace:
  nf_nat_ipv4_out+0x78/0x90 [nf_nat_ipv4]
  nf_hook_slow+0x36/0xd0
  ip_output+0x9f/0xd0
  ip_forward+0x328/0x440
  ip_rcv+0x8a/0xb0

Use dst_hold_safe instead and bail out if we cannot take a reference.

Fixes: a4c2fd7f78 ("net: remove DST_NOCACHE flag")
Reported-by: Martin Zaharinov <micron10@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-01-13 10:00:58 +01:00
..
ipset
netfilter: ipset: do not call ipset_nest_end after nla_nest_cancel
2019-01-13 10:00:58 +01:00
ipvs
ipvs: call ip_vs_dst_notifier earlier than ipv6_dev_notf
2018-12-17 09:28:51 +01:00
core.c
netfilter: core: remove erroneous warn_on
2017-09-08 18:55:52 +02:00
Kconfig
…
Makefile
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
nf_conntrack_acct.c
…
nf_conntrack_amanda.c
…
nf_conntrack_broadcast.c
…
nf_conntrack_core.c
netfilter: conntrack: fix calculation of next bucket number in early_drop
2018-11-21 09:24:09 +01:00
nf_conntrack_ecache.c
…
nf_conntrack_expect.c
net: Replace NF_CT_ASSERT() with WARN_ON().
2017-09-04 13:25:19 +02:00
nf_conntrack_extend.c
net: Replace NF_CT_ASSERT() with WARN_ON().
2017-09-04 13:25:19 +02:00
nf_conntrack_ftp.c
…
nf_conntrack_h323_asn1.c
…
nf_conntrack_h323_main.c
…
nf_conntrack_h323_types.c
…
nf_conntrack_helper.c
netfilter: nf_ct_helper: Fix possible panic after nf_conntrack_helper_unregister
2018-08-24 13:08:57 +02:00
nf_conntrack_irc.c
…
nf_conntrack_l3proto_generic.c
…
nf_conntrack_labels.c
…
nf_conntrack_netbios_ns.c
…
nf_conntrack_netlink.c
netfilter: fix memory leaks on netlink_dump_start error
2018-09-15 09:45:28 +02:00
nf_conntrack_pptp.c
…
nf_conntrack_proto_dccp.c
netfilter: conntrack: dccp: treat SYNC/SYNCACK as invalid if no prior state
2018-08-24 13:09:22 +02:00
nf_conntrack_proto_generic.c
netfilter: remove unused hooknum arg from packet functions
2017-09-04 13:25:18 +02:00
nf_conntrack_proto_gre.c
netfilter: remove unused hooknum arg from packet functions
2017-09-04 13:25:18 +02:00
nf_conntrack_proto_sctp.c
netfilter: remove unused hooknum arg from packet functions
2017-09-04 13:25:18 +02:00
nf_conntrack_proto_tcp.c
netfilter: remove unused hooknum arg from packet functions
2017-09-04 13:25:18 +02:00
nf_conntrack_proto_udp.c
netfilter: remove unused hooknum arg from packet functions
2017-09-04 13:25:18 +02:00
nf_conntrack_proto.c
…
nf_conntrack_sane.c
…
nf_conntrack_seqadj.c
netfilter: seqadj: re-load tcp header pointer after possible head reallocation
2019-01-13 10:00:57 +01:00
nf_conntrack_sip.c
…
nf_conntrack_snmp.c
…
nf_conntrack_standalone.c
net: Replace NF_CT_ASSERT() with WARN_ON().
2017-09-04 13:25:19 +02:00
nf_conntrack_tftp.c
…
nf_conntrack_timeout.c
…
nf_conntrack_timestamp.c
…
nf_dup_netdev.c
…
nf_internals.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
nf_log_common.c
…
nf_log_netdev.c
…
nf_log.c
netfilter: nf_log: fix uninit read in nf_log_proc_dostring
2018-08-24 13:09:07 +02:00
nf_nat_amanda.c
…
nf_nat_core.c
netfilter: nat: can't use dst_hold on noref dst
2019-01-13 10:00:58 +01:00
nf_nat_ftp.c
…
nf_nat_helper.c
…
nf_nat_irc.c
…
nf_nat_proto_common.c
netfilter: nat: cope with negative port range
2018-03-15 10:54:23 +01:00
nf_nat_proto_dccp.c
…
nf_nat_proto_sctp.c
…
nf_nat_proto_tcp.c
…
nf_nat_proto_udp.c
…
nf_nat_proto_unknown.c
…
nf_nat_redirect.c
net: Replace NF_CT_ASSERT() with WARN_ON().
2017-09-04 13:25:19 +02:00
nf_nat_sip.c
…
nf_nat_tftp.c
…
nf_queue.c
netfilter: convert hook list to an array
2017-08-28 17:44:00 +02:00
nf_sockopt.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
nf_synproxy_core.c
…
nf_tables_api.c
netfilter: nf_tables: deactivate expressions in rule replecement routine
2018-12-17 09:28:52 +01:00
nf_tables_core.c
netfilter: nf_tables: use WARN_ON_ONCE instead of BUG_ON in nft_do_chain()
2018-07-08 15:30:50 +02:00
nf_tables_inet.c
…
nf_tables_netdev.c
…
nf_tables_trace.c
…
nfnetlink_acct.c
netfilter: fix memory leaks on netlink_dump_start error
2018-09-15 09:45:28 +02:00
nfnetlink_cthelper.c
netfilter: nfnetlink_cthelper: Add missing permission checks
2018-01-31 14:03:41 +01:00
nfnetlink_cttimeout.c
…
nfnetlink_log.c
…
nfnetlink_queue.c
netfilter: nf_queue: augment nfqa_cfg_policy
2018-07-17 11:39:32 +02:00
nfnetlink.c
…
nft_bitwise.c
…
nft_byteorder.c
…
nft_cmp.c
…
nft_compat.c
netfilter: nf_tables: fix use-after-free when deleting compat expressions
2018-12-17 09:28:48 +01:00
nft_counter.c
netfilter: nf_tables: add select_ops for stateful objects
2017-09-04 13:25:09 +02:00
nft_ct.c
netfilter: nf_tables: fix NULL pointer dereference on nft_ct_helper_obj_dump()
2018-06-16 09:45:14 +02:00
nft_dup_netdev.c
…
nft_dynset.c
…
nft_exthdr.c
netfilter: fix a few (harmless) sparse warnings
2017-08-28 17:42:56 +02:00
nft_fib_inet.c
…
nft_fib_netdev.c
…
nft_fib.c
…
nft_fwd_netdev.c
…
nft_hash.c
…
nft_immediate.c
netfilter: nf_tables: bogus EBUSY in chain deletions
2018-07-08 15:30:49 +02:00
nft_limit.c
netfilter: nft_limit: fix packet ratelimiting
2018-07-08 15:30:51 +02:00
nft_log.c
…
nft_lookup.c
…
nft_masq.c
…
nft_meta.c
netfilter: nft_meta: fix wrong value dereference in nft_meta_set_eval
2018-07-08 15:30:49 +02:00
nft_nat.c
…
nft_numgen.c
…
nft_objref.c
netfilter: nf_tables: add select_ops for stateful objects
2017-09-04 13:25:09 +02:00
nft_payload.c
netfilter: fix a few (harmless) sparse warnings
2017-08-28 17:42:56 +02:00
nft_queue.c
…
nft_quota.c
netfilter: nf_tables: add select_ops for stateful objects
2017-09-04 13:25:09 +02:00
nft_range.c
…
nft_redir.c
…
nft_reject_inet.c
…
nft_reject.c
…
nft_rt.c
netfilter: rt: account for tcp header size too
2017-08-28 18:14:30 +02:00
nft_set_bitmap.c
…
nft_set_hash.c
netfilter: nft_set_hash: add rcu_barrier() in the nft_rhash_destroy()
2018-09-05 09:26:27 +02:00
nft_set_rbtree.c
…
x_tables.c
netfilter: x_tables: limit allocation requests for blob rule heads
2018-04-26 11:02:21 +02:00
xt_addrtype.c
…
xt_AUDIT.c
…
xt_bpf.c
netfilter: xt_bpf: add overflow checks
2018-02-25 11:08:01 +01:00
xt_cgroup.c
netfilter: xt_cgroup: initialize info->priv in cgroup_mt_check_v1()
2018-02-25 11:07:50 +01:00
xt_CHECKSUM.c
…
xt_CLASSIFY.c
…
xt_cluster.c
netfilter: xt_cluster: add dependency on conntrack module
2018-10-10 08:54:23 +02:00
xt_comment.c
…
xt_connbytes.c
…
xt_connlabel.c
…
xt_connlimit.c
netfilter: nf_conncount: don't skip eviction when age is negative
2019-01-09 17:14:51 +01:00
xt_connmark.c
…
xt_CONNSECMARK.c
…
xt_conntrack.c
…
xt_cpu.c
…
xt_CT.c
…
xt_dccp.c
…
xt_devgroup.c
…
xt_dscp.c
…
xt_DSCP.c
…
xt_ecn.c
…
xt_esp.c
…
xt_hashlimit.c
netfilter: xt_hashlimit: fix a possible memory leak in htable_create()
2018-12-17 09:28:49 +01:00
xt_helper.c
…
xt_hl.c
…
xt_HL.c
…
xt_HMARK.c
…
xt_IDLETIMER.c
netfilter: xt_IDLETIMER: add sysfs filename checking routine
2018-11-27 16:10:48 +01:00
xt_ipcomp.c
…
xt_iprange.c
…
xt_ipvs.c
…
xt_l2tp.c
…
xt_LED.c
netfilter: x_tables: fix pointer leaks to userspace
2018-04-26 11:02:13 +02:00
xt_length.c
…
xt_limit.c
netfilter: x_tables: fix pointer leaks to userspace
2018-04-26 11:02:13 +02:00
xt_LOG.c
…
xt_mac.c
…
xt_mark.c
…
xt_multiport.c
…
xt_nat.c
net: Replace NF_CT_ASSERT() with WARN_ON().
2017-09-04 13:25:19 +02:00
xt_NETMAP.c
net: Replace NF_CT_ASSERT() with WARN_ON().
2017-09-04 13:25:19 +02:00
xt_nfacct.c
netfilter: x_tables: fix pointer leaks to userspace
2018-04-26 11:02:13 +02:00
xt_NFLOG.c
…
xt_NFQUEUE.c
…
xt_osf.c
netfilter: xt_osf: Add missing permission checks
2018-01-31 14:03:41 +01:00
xt_owner.c
…
xt_physdev.c
…
xt_pkttype.c
…
xt_policy.c
…
xt_quota.c
…
xt_rateest.c
…
xt_RATEEST.c
netfilter: xt_RATEEST: acquire xt_rateest_mutex for hash insert
2018-02-25 11:07:50 +01:00
xt_realm.c
…
xt_recent.c
netfilter: x_tables: add and use xt_check_proc_name
2018-04-08 14:26:29 +02:00
xt_REDIRECT.c
…
xt_repldata.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xt_sctp.c
…
xt_SECMARK.c
…
xt_set.c
…
xt_socket.c
netfilter: xt_socket: Restore mark from full sockets only
2017-09-26 20:04:34 +02:00
xt_state.c
…
xt_statistic.c
netfilter: x_tables: fix pointer leaks to userspace
2018-04-26 11:02:13 +02:00
xt_string.c
…
xt_tcpmss.c
…
xt_TCPMSS.c
…
xt_TCPOPTSTRIP.c
…
xt_tcpudp.c
…
xt_TEE.c
…
xt_time.c
…
xt_TPROXY.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next
2017-09-03 17:08:42 -07:00
xt_TRACE.c
…
xt_u32.c
…