Eric Dumazet
33e1cea2dc
net: add annotations on hh->hh_len lockless accesses
[ Upstream commit c305c6ae79 ]
KCSAN reported a data-race [1]
While we can use READ_ONCE() on the read sides,
we need to make sure hh->hh_len is written last.
[1]
BUG: KCSAN: data-race in eth_header_cache / neigh_resolve_output
write to 0xffff8880b9dedcb8 of 4 bytes by task 29760 on cpu 0:
eth_header_cache+0xa9/0xd0 net/ethernet/eth.c:247
neigh_hh_init net/core/neighbour.c:1463 [inline]
neigh_resolve_output net/core/neighbour.c:1480 [inline]
neigh_resolve_output+0x415/0x470 net/core/neighbour.c:1470
neigh_output include/net/neighbour.h:511 [inline]
ip6_finish_output2+0x7a2/0xec0 net/ipv6/ip6_output.c:116
__ip6_finish_output net/ipv6/ip6_output.c:142 [inline]
__ip6_finish_output+0x2d7/0x330 net/ipv6/ip6_output.c:127
ip6_finish_output+0x41/0x160 net/ipv6/ip6_output.c:152
NF_HOOK_COND include/linux/netfilter.h:294 [inline]
ip6_output+0xf2/0x280 net/ipv6/ip6_output.c:175
dst_output include/net/dst.h:436 [inline]
NF_HOOK include/linux/netfilter.h:305 [inline]
ndisc_send_skb+0x459/0x5f0 net/ipv6/ndisc.c:505
ndisc_send_ns+0x207/0x430 net/ipv6/ndisc.c:647
rt6_probe_deferred+0x98/0xf0 net/ipv6/route.c:615
process_one_work+0x3d4/0x890 kernel/workqueue.c:2269
worker_thread+0xa0/0x800 kernel/workqueue.c:2415
kthread+0x1d4/0x200 drivers/block/aoe/aoecmd.c:1253
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
read to 0xffff8880b9dedcb8 of 4 bytes by task 29572 on cpu 1:
neigh_resolve_output net/core/neighbour.c:1479 [inline]
neigh_resolve_output+0x113/0x470 net/core/neighbour.c:1470
neigh_output include/net/neighbour.h:511 [inline]
ip6_finish_output2+0x7a2/0xec0 net/ipv6/ip6_output.c:116
__ip6_finish_output net/ipv6/ip6_output.c:142 [inline]
__ip6_finish_output+0x2d7/0x330 net/ipv6/ip6_output.c:127
ip6_finish_output+0x41/0x160 net/ipv6/ip6_output.c:152
NF_HOOK_COND include/linux/netfilter.h:294 [inline]
ip6_output+0xf2/0x280 net/ipv6/ip6_output.c:175
dst_output include/net/dst.h:436 [inline]
NF_HOOK include/linux/netfilter.h:305 [inline]
ndisc_send_skb+0x459/0x5f0 net/ipv6/ndisc.c:505
ndisc_send_ns+0x207/0x430 net/ipv6/ndisc.c:647
rt6_probe_deferred+0x98/0xf0 net/ipv6/route.c:615
process_one_work+0x3d4/0x890 kernel/workqueue.c:2269
worker_thread+0xa0/0x800 kernel/workqueue.c:2415
kthread+0x1d4/0x200 drivers/block/aoe/aoecmd.c:1253
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 29572 Comm: kworker/1:4 Not tainted 5.4.0-rc6+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events rt6_probe_deferred
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-01-09 10:17:59 +01:00
..
2019-06-25 11:36:54 +08:00
2019-05-08 07:20:45 +02:00
2019-11-12 19:18:08 +01:00
2019-06-17 19:52:44 +02:00
2019-05-16 19:42:32 +02:00
2019-03-23 14:35:16 +01:00
2019-12-05 15:38:18 +01:00
2019-05-04 09:15:20 +02:00
2019-09-10 10:32:20 +01:00
2019-08-04 09:31:59 +02:00
2019-06-11 12:21:51 +02:00
2019-02-23 09:06:44 +01:00
2019-11-12 19:17:46 +01:00
2019-11-10 11:25:24 +01:00
2020-01-04 14:00:14 +01:00
2020-01-04 14:00:16 +01:00
2019-11-10 11:25:37 +01:00
2019-11-10 11:25:37 +01:00
2019-11-10 11:25:37 +01:00
2019-03-13 14:03:09 -07:00
2018-04-29 11:33:13 +02:00
2019-04-27 09:35:40 +02:00
2020-01-04 14:00:19 +01:00
2018-10-18 09:16:21 +02:00
2018-05-16 10:10:24 +02:00
2019-02-23 09:06:42 +01:00
2019-06-11 12:21:47 +02:00
2019-07-21 09:04:28 +02:00
2019-01-31 08:13:42 +01:00
2019-11-12 19:18:38 +01:00
2019-12-21 10:47:38 +01:00
2019-09-16 08:20:44 +02:00
2019-04-27 09:35:40 +02:00
2019-02-06 17:31:33 +01:00
2019-11-06 12:43:36 +01:00
2019-11-20 17:59:59 +01:00
2018-05-30 07:51:58 +02:00
2020-01-09 10:17:59 +01:00
2019-04-17 08:37:50 +02:00
2018-05-16 10:10:23 +02:00
2019-09-10 10:32:21 +01:00
2018-02-25 11:07:59 +01:00
2018-05-30 07:52:01 +02:00
2018-05-30 07:52:14 +02:00
2019-11-06 12:43:39 +01:00
2018-04-19 08:56:16 +02:00
2020-01-04 14:00:19 +01:00
2019-12-21 10:47:37 +01:00
2018-12-05 19:41:10 +01:00
2018-06-26 08:06:28 +08:00
2018-06-26 08:06:28 +08:00
2018-03-08 22:41:10 -08:00
2019-09-16 08:20:44 +02:00