Files
i2som-imx-linux/include/linux
Eric Dumazet 11db1e4cee tcp: must unclone packets before mangling them
[ Upstream commit c52e2421f7 ]

TCP stack should make sure it owns skbs before mangling them.

We had various crashes using bnx2x, and it turned out gso_size
was cleared right before bnx2x driver was populating TC descriptor
of the _previous_ packet send. TCP stack can sometime retransmit
packets that are still in Qdisc.

Of course we could make bnx2x driver more robust (using
ACCESS_ONCE(shinfo->gso_size) for example), but the bug is TCP stack.

We have identified two points where skb_unclone() was needed.

This patch adds a WARN_ON_ONCE() to warn us if we missed another
fix of this kind.

Kudos to Neal for finding the root cause of this bug. Its visible
using small MSS.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-04 04:23:40 -08:00
..
2012-11-26 11:38:03 -08:00
2012-04-23 14:23:32 +03:00
2012-04-27 11:03:38 -06:00
2012-11-17 13:16:12 -08:00
2012-04-27 10:46:45 +08:00
2013-07-28 16:25:59 -07:00
2012-10-02 10:30:35 -07:00
2012-08-15 08:10:29 -07:00
2012-07-19 08:59:00 -07:00
2013-04-16 21:27:26 -07:00
2012-10-02 10:30:05 -07:00
2012-12-17 10:37:42 -08:00
2012-08-09 08:31:30 -07:00
2013-01-11 09:07:15 -08:00
2012-07-16 09:04:42 -07:00
2013-04-05 10:04:40 -07:00
2013-08-04 16:26:03 +08:00