Peter Zijlstra
7c3f08eadc
sched/topology: Fix building of overlapping sched-groups
commit 0372dd2736 upstream.
When building the overlapping groups, we very obviously should start
with the previous domain of _this_ @cpu, not CPU-0.
This can be readily demonstrated with a topology like:
node 0 1 2 3
0: 10 20 30 20
1: 20 10 20 30
2: 30 20 10 20
3: 20 30 20 10
Where (for example) CPU1 ends up generating the following nonsensical groups:
[] CPU1 attaching sched-domain:
[] domain 0: span 0-2 level NUMA
[] groups: 1 2 0
[] domain 1: span 0-3 level NUMA
[] groups: 1-3 (cpu_capacity = 3072) 0-1,3 (cpu_capacity = 3072)
Where the fact that domain 1 doesn't include a group with span 0-2 is
the obvious fail.
With patch this looks like:
[] CPU1 attaching sched-domain:
[] domain 0: span 0-2 level NUMA
[] groups: 1 0 2
[] domain 1: span 0-3 level NUMA
[] groups: 0-2 (cpu_capacity = 3072) 0,2-3 (cpu_capacity = 3072)
Debugged-by: Lauro Ramos Venancio <lvenanci@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Fixes: e3589f6c81 ("sched: Allow for overlapping sched_domain spans")
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-07-21 07:42:23 +02:00
..
2017-07-21 07:42:18 +02:00
2016-10-11 15:06:32 -07:00
2017-01-06 10:40:17 +01:00
2017-07-05 14:40:26 +02:00
2017-06-24 07:11:17 +02:00
2017-07-15 12:16:15 +02:00
2016-11-02 05:10:04 +01:00
2017-02-23 17:44:36 +01:00
2017-07-21 07:42:22 +02:00
2017-07-21 07:42:23 +02:00
2017-06-29 13:00:30 +02:00
2017-07-12 15:01:02 +02:00
2016-10-04 14:21:41 -07:00
2016-10-04 14:21:41 -07:00
2017-01-06 10:40:13 +01:00
2017-03-26 13:05:58 +02:00
2017-06-14 15:06:00 +02:00
2017-06-14 15:06:04 +02:00
2017-06-14 15:06:00 +02:00
2016-11-22 12:33:43 +01:00
2017-07-21 07:42:21 +02:00
2017-05-25 15:44:46 +02:00
2017-03-22 12:43:40 +01:00
2016-10-07 18:46:30 -07:00
2016-10-11 15:06:33 -07:00
2017-01-19 20:17:59 +01:00
2016-12-07 17:10:00 -08:00
2017-05-25 15:44:47 +02:00
2017-04-21 09:31:18 +02:00
2017-06-17 06:41:57 +02:00
2017-03-12 06:41:45 +01:00
2017-03-12 06:41:43 +01:00
2016-11-29 16:01:30 -08:00
2017-05-20 14:28:40 +02:00
2017-07-05 14:40:24 +02:00
2017-05-25 15:44:38 +02:00
2017-06-14 15:05:54 +02:00
2017-01-12 11:39:30 +01:00
2017-06-29 13:00:29 +02:00
2016-09-22 14:49:10 +02:00
2016-10-11 15:06:33 -07:00
2016-10-21 15:45:47 -06:00
2017-02-14 15:25:42 -08:00
2016-10-03 13:39:00 -07:00
2016-09-13 14:41:36 +02:00
2017-07-12 15:01:04 +02:00
2016-11-03 16:55:58 -04:00
2017-06-17 06:41:51 +02:00
2016-10-07 18:46:30 -07:00
2016-09-05 13:52:39 +02:00
2016-09-22 20:00:36 -05:00
2016-09-22 20:00:36 -05:00
2017-06-17 06:41:57 +02:00
2017-06-17 06:41:57 +02:00
2016-10-11 15:06:33 -07:00