Cong Wang 66ac8ee96f net_sched: fix datalen for ematch ...

[ Upstream commit 61678d28d4 ]

syzbot reported an out-of-bound access in em_nbyte. As initially
analyzed by Eric, this is because em_nbyte sets its own em->datalen
in em_nbyte_change() other than the one specified by user, but this
value gets overwritten later by its caller tcf_em_validate().
We should leave em->datalen untouched to respect their choices.

I audit all the in-tree ematch users, all of those implement
->change() set em->datalen, so we can just avoid setting it twice
in this case.

Reported-and-tested-by: syzbot+5af9a90dad568aa9f611@syzkaller.appspotmail.com
Reported-by: syzbot+2f07903a5b05e7f36410@syzkaller.appspotmail.com
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2020-01-29 16:43:16 +01:00

..

act_api.c

net: avoid potential infinite loop in tc_ctl_action()

2019-10-29 09:19:39 +01:00

act_bpf.c

…

act_connmark.c

…

act_csum.c

net: sched: act_csum: Fix csum calc for tagged packets

2020-01-27 14:50:29 +01:00

act_gact.c

…

act_ife.c

…

act_ipt.c

…

act_meta_mark.c

…

act_meta_skbprio.c

…

act_meta_skbtcindex.c

…

act_mirred.c

act_mirred: Fix mirred_init_module error handling

2020-01-27 14:51:18 +01:00

act_nat.c

…

act_pedit.c

net/sched: act_pedit: fix WARN() in the traffic path

2019-12-01 09:16:06 +01:00

act_police.c

…

act_sample.c

net/sched: act_sample: don't push mac header on ip6gre ingress

2019-10-05 13:09:28 +02:00

act_simple.c

…

act_skbedit.c

…

act_skbmod.c

…

act_tunnel_key.c

net: sched: ensure opts_len <= IP_TUNNEL_OPTS_MAX in act_tunnel_key

2019-12-01 09:16:06 +01:00

act_vlan.c

…

cls_api.c

net: sched: fix possible crash in tcf_action_destroy()

2019-10-05 13:09:30 +02:00

cls_basic.c

…

cls_bpf.c

…

cls_cgroup.c

…

cls_flow.c

…

cls_flower.c

…

cls_fw.c

…

cls_matchall.c

…

cls_route.c

…

cls_rsvp6.c

…

cls_rsvp.c

…

cls_rsvp.h

…

cls_tcindex.c

…

cls_u32.c

…

em_canid.c

…

em_cmp.c

…

em_ipset.c

…

em_ipt.c

…

em_meta.c

…

em_nbyte.c

…

em_text.c

…

em_u32.c

…

ematch.c

net_sched: fix datalen for ematch

2020-01-29 16:43:16 +01:00

Kconfig

…

Makefile

…

sch_api.c

net_sched: add max len check for TCA_KIND

2019-10-05 13:09:28 +02:00

sch_atm.c

…

sch_blackhole.c

…

sch_cake.c

sch_cake: avoid possible divide by zero in cake_enqueue()

2020-01-12 12:17:26 +01:00

sch_cbq.c

sch_cbq: validate TCA_CBQ_WRROPT to avoid crash

2019-10-07 18:57:26 +02:00

sch_cbs.c

net: sched: cbs: Avoid division by zero when calculating the port rate

2020-01-27 14:51:16 +01:00

sch_choke.c

…

sch_codel.c

…

sch_drr.c

…

sch_dsmark.c

sch_dsmark: fix potential NULL deref in dsmark_init()

2019-10-07 18:57:23 +02:00

sch_etf.c

…

sch_fifo.c

…

sch_fq_codel.c

…

sch_fq.c

pkt_sched: fq: do not accept silly TCA_FQ_QUANTUM

2020-01-12 12:17:26 +01:00

sch_generic.c

net: sched: avoid writing on noop_qdisc

2019-11-24 08:21:02 +01:00

sch_gred.c

…

sch_hfsc.c

…

sch_hhf.c

net/flow_dissector: switch to siphash

2019-11-10 11:27:54 +01:00

sch_htb.c

…

sch_ingress.c

…

sch_mq.c

net: sched: fix dump qlen for sch_mq/sch_mqprio with NOLOCK subqueues

2019-12-21 10:57:12 +01:00

sch_mqprio.c

net: sched: fix dump qlen for sch_mq/sch_mqprio with NOLOCK subqueues

2019-12-21 10:57:12 +01:00

sch_multiq.c

net: sched: fix tc -s class show no bstats on class with nolock subqueues

2019-12-05 09:21:32 +01:00

sch_netem.c

net: netem: correct the parent's backlog when corrupted packet was dropped

2020-01-27 14:51:19 +01:00

sch_pie.c

…

sch_plug.c

…

sch_prio.c

net: sch_prio: When ungrafting, replace with FIFO

2020-01-12 12:17:29 +01:00

sch_qfq.c

…

sch_red.c

…

sch_sfb.c

net/flow_dissector: switch to siphash

2019-11-10 11:27:54 +01:00

sch_sfq.c

net/flow_dissector: switch to siphash

2019-11-10 11:27:54 +01:00

sch_skbprio.c

…

sch_tbf.c

…

sch_teql.c

…