iMX/i2som-imx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
a6bae0cefc34940ede720cf2eb04e87bd41e8757
i2som-imx-linux/block
History
Junichi Nomura bc6024b427 block: check bi_size overflow before merge 
[ Upstream commit e3a5d8e386 ]

__bio_try_merge_page() may merge a page to bio without bio_full() check
and cause bi_size overflow.

The overflow typically ends up with sd_init_command() warning on zero
segment request with call trace like this:

    ------------[ cut here ]------------
    WARNING: CPU: 2 PID: 1986 at drivers/scsi/scsi_lib.c:1025 scsi_init_io+0x156/0x180
    CPU: 2 PID: 1986 Comm: kworker/2:1H Kdump: loaded Not tainted 5.4.0-rc7 #1
    Workqueue: kblockd blk_mq_run_work_fn
    RIP: 0010:scsi_init_io+0x156/0x180
    RSP: 0018:ffffa11487663bf0 EFLAGS: 00010246
    RAX: 00000000002be0a0 RBX: ffff8e6e9ff30118 RCX: 0000000000000000
    RDX: 00000000ffffffe1 RSI: 0000000000000000 RDI: ffff8e6e9ff30118
    RBP: ffffa11487663c18 R08: ffffa11487663d28 R09: ffff8e6e9ff30150
    R10: 0000000000000001 R11: 0000000000000000 R12: ffff8e6e9ff30000
    R13: 0000000000000001 R14: ffff8e74a1cf1800 R15: ffff8e6e9ff30000
    FS:  0000000000000000(0000) GS:ffff8e6ea7680000(0000) knlGS:0000000000000000
    CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    CR2: 00007fff18cf0fe8 CR3: 0000000659f0a001 CR4: 00000000001606e0
    Call Trace:
     sd_init_command+0x326/0xb40 [sd_mod]
     scsi_queue_rq+0x502/0xaa0
     ? blk_mq_get_driver_tag+0xe7/0x120
     blk_mq_dispatch_rq_list+0x256/0x5a0
     ? elv_rb_del+0x24/0x30
     ? deadline_remove_request+0x7b/0xc0
     blk_mq_do_dispatch_sched+0xa3/0x140
     blk_mq_sched_dispatch_requests+0xfb/0x170
     __blk_mq_run_hw_queue+0x81/0x130
     blk_mq_run_work_fn+0x1b/0x20
     process_one_work+0x179/0x390
     worker_thread+0x4f/0x3e0
     kthread+0x105/0x140
     ? max_active_store+0x80/0x80
     ? kthread_bind+0x20/0x20
     ret_from_fork+0x35/0x40
    ---[ end trace f9036abf5af4a4d3 ]---
    blk_update_request: I/O error, dev sdd, sector 2875552 op 0x1:(WRITE) flags 0x0 phys_seg 0 prio class 0
    XFS (sdd1): writeback error on sector 2875552

__bio_try_merge_page() should check the overflow before actually doing
merge.

Fixes: 07173c3ec2 ("block: enable multipage bvecs")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-12-13 08:48:35 +01:00
..
partitions
docs: admin-guide: add a series of orphaned documents
2019-07-15 11:03:02 -03:00
badblocks.c
block: switch all files cleared marked as GPLv2 to SPDX tags
2019-04-30 16:11:57 -06:00
bfq-cgroup.c
block: rename CONFIG_DEBUG_BLK_CGROUP to CONFIG_BFQ_CGROUP_DEBUG
2019-06-20 10:32:35 -06:00
bfq-iosched.c
block, bfq: deschedule empty bfq_queues not referred by any process
2019-11-24 08:16:59 +01:00
bfq-iosched.h
block, bfq: detect wakers and unconditionally inject their I/O
2019-06-25 09:07:34 -06:00
bfq-wf2q.c
block: switch all files cleared marked as GPLv2 or later to SPDX tags
2019-04-30 16:11:59 -06:00
bio-integrity.c
block/bio-integrity: fix a memory leak bug
2019-07-11 20:01:21 -06:00
bio.c
block: check bi_size overflow before merge
2019-12-13 08:48:35 +01:00
blk-cgroup.c
blkcg: make blkcg_print_stat() print stats only for online blkgs
2019-11-12 19:27:04 +01:00
blk-core.c
block: Disable write plugging for zoned block devices
2019-07-10 14:18:01 -06:00
blk-exec.c
block: add SPDX tags to block layer files missing licensing information
2019-04-30 16:12:03 -06:00
blk-flush.c
block: fix null pointer dereference in blk_mq_rq_timed_out()
2019-10-05 15:12:29 +02:00
blk-integrity.c
docs: block: convert to ReST
2019-07-15 09:20:27 -03:00
blk-ioc.c
block: remove the queue_lock indirection
2018-11-15 12:17:28 -07:00
blk-iolatency.c
blkcg: allow blkcg_policy->pd_stat() to print non-debug info too
2019-07-16 10:06:39 -06:00
blk-lib.c
block: fix 32 bit overflow in __blkdev_issue_discard()
2018-11-14 08:17:18 -07:00
blk-map.c
block: remove the bi_phys_segments field in struct bio
2019-06-20 10:29:22 -06:00
blk-merge.c
block: nr_phys_segments needs to be zero for REQ_OP_WRITE_ZEROES
2019-07-03 07:20:40 -06:00
blk-mq-cpumap.c
blk-mq: Document the blk_mq_hw_queue_to_node() arguments
2019-05-31 15:12:34 -06:00
blk-mq-debugfs-zoned.c
block: Cleanup license notice
2019-01-17 21:21:40 -07:00
blk-mq-debugfs.c
Merge tag 'for-5.3/block-20190708' of git://git.kernel.dk/linux-block
2019-07-09 10:45:06 -07:00
blk-mq-debugfs.h
blk-mq: no need to check return value of debugfs_create functions
2019-06-13 03:00:30 -06:00
blk-mq-pci.c
block: Fix blk_mq_*_map_queues() kernel-doc headers
2019-05-31 15:12:34 -06:00
blk-mq-rdma.c
block: Fix blk_mq_*_map_queues() kernel-doc headers
2019-05-31 15:12:34 -06:00
blk-mq-sched.c
blk-mq: move lockdep_assert_held() into elevator_exit
2019-10-11 18:36:47 +02:00
blk-mq-sched.h
block: blk-mq: Remove blk_mq_sched_started_request and started_request
2019-07-23 07:25:09 -06:00
blk-mq-sysfs.c
Merge tag 'for-5.2/block-20190507' of git://git.kernel.dk/linux-block
2019-05-07 18:14:36 -07:00
blk-mq-tag.c
blk-mq: remove blk_mq_put_ctx()
2019-07-02 21:03:27 -06:00
blk-mq-tag.h
Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block
2017-11-14 15:32:19 -08:00
blk-mq-virtio.c
block: Fix blk_mq_*_map_queues() kernel-doc headers
2019-05-31 15:12:34 -06:00
blk-mq.c
blk-mq: honor IO scheduler for multiqueue devices
2019-10-29 09:21:32 +01:00
blk-mq.h
block: Disable write plugging for zoned block devices
2019-07-10 14:18:01 -06:00
blk-pm.c
block: remove the queue_lock indirection
2018-11-15 12:17:28 -07:00
blk-pm.h
block: remove the queue_lock indirection
2018-11-15 12:17:28 -07:00
blk-rq-qos.c
blk-wbt: fix performance regression in wbt scale_up/scale_down
2019-10-17 13:47:13 -07:00
blk-rq-qos.h
blk-rq-qos: fix first node deletion of rq_qos_del()
2019-10-29 09:22:47 +01:00
blk-settings.c
block: fix max segment size handling in blk_queue_virt_boundary
2019-07-26 12:50:57 -06:00
blk-softirq.c
block: remove a few unused exports
2018-11-15 12:13:25 -07:00
blk-stat.c
block: add SPDX tags to block layer files missing licensing information
2019-04-30 16:12:03 -06:00
blk-stat.h
block: deactivate blk_stat timer in wbt_disable_default()
2018-12-12 06:47:51 -07:00
blk-sysfs.c
blk-mq: move cancel of requeue_work to the front of blk_exit_queue
2019-08-12 08:14:11 -06:00
blk-throttle.c
block: make rq sector size accessible for block stats
2019-10-05 15:12:06 +02:00
blk-timeout.c
block: add SPDX tags to block layer files missing licensing information
2019-04-30 16:12:03 -06:00
blk-wbt.c
blk-wbt: fix performance regression in wbt scale_up/scale_down
2019-10-17 13:47:13 -07:00
blk-wbt.h
block: remove external dependency on wbt_flags
2018-07-09 09:07:54 -06:00
blk-zoned.c
block: Limit zone array allocation size
2019-07-11 20:04:40 -06:00
blk.h
blk-mq: move lockdep_assert_held() into elevator_exit
2019-10-11 18:36:47 +02:00
bounce.c
block: remove the i argument to bio_for_each_segment_all
2019-04-30 09:26:13 -06:00
bsg-lib.c
block: Fix bsg_setup_queue() kernel-doc header
2019-05-31 15:12:34 -06:00
bsg.c
block: switch all files cleared marked as GPLv2 to SPDX tags
2019-04-30 16:11:57 -06:00
cmdline-parser.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
compat_ioctl.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
elevator.c
block: free sched's request pool in blk_cleanup_queue
2019-06-06 22:39:39 -06:00
genhd.c
block: fix sysfs module parameters directory path in comment
2019-07-16 10:16:33 -06:00
ioctl.c
block: add SPDX tags to block layer files missing licensing information
2019-04-30 16:12:03 -06:00
ioprio.c
docs: block: convert to ReST
2019-07-15 09:20:27 -03:00
Kconfig
docs: cgroup-v1: add it to the admin-guide book
2019-07-15 11:03:02 -03:00
Kconfig.iosched
docs: block: convert to ReST
2019-07-15 09:20:27 -03:00
kyber-iosched.c
blk-mq: remove blk_mq_put_ctx()
2019-07-02 21:03:27 -06:00
Makefile
block: remove legacy IO schedulers
2018-11-07 13:42:32 -07:00
mq-deadline.c
block: mq-deadline: Fix queue restart handling
2019-10-05 15:12:29 +02:00
opal_proto.h
block: sed-opal: check size of shadow mbr
2019-06-29 10:34:08 -06:00
partition-generic.c
block: fix use-after-free on gendisk
2019-04-22 09:48:12 -06:00
scsi_ioctl.c
block: switch all files cleared marked as GPLv2 to SPDX tags
2019-04-30 16:11:57 -06:00
sed-opal.c
block: sed-opal: check size of shadow mbr
2019-06-29 10:34:08 -06:00
t10-pi.c
block: switch all files cleared marked as GPLv2 to SPDX tags
2019-04-30 16:11:57 -06:00