Peter Zijlstra f3022d3db3 perf: Fix irq_work 'tail' recursion ...

commit d525211f9d upstream.

Vince reported a watchdog lockup like:

	[<ffffffff8115e114>] perf_tp_event+0xc4/0x210
	[<ffffffff810b4f8a>] perf_trace_lock+0x12a/0x160
	[<ffffffff810b7f10>] lock_release+0x130/0x260
	[<ffffffff816c7474>] _raw_spin_unlock_irqrestore+0x24/0x40
	[<ffffffff8107bb4d>] do_send_sig_info+0x5d/0x80
	[<ffffffff811f69df>] send_sigio_to_task+0x12f/0x1a0
	[<ffffffff811f71ce>] send_sigio+0xae/0x100
	[<ffffffff811f72b7>] kill_fasync+0x97/0xf0
	[<ffffffff8115d0b4>] perf_event_wakeup+0xd4/0xf0
	[<ffffffff8115d103>] perf_pending_event+0x33/0x60
	[<ffffffff8114e3fc>] irq_work_run_list+0x4c/0x80
	[<ffffffff8114e448>] irq_work_run+0x18/0x40
	[<ffffffff810196af>] smp_trace_irq_work_interrupt+0x3f/0xc0
	[<ffffffff816c99bd>] trace_irq_work_interrupt+0x6d/0x80

Which is caused by an irq_work generating new irq_work and therefore
not allowing forward progress.

This happens because processing the perf irq_work triggers another
perf event (tracepoint stuff) which in turn generates an irq_work ad
infinitum.

Avoid this by raising the recursion counter in the irq_work -- which
effectively disables all software events (including tracepoints) from
actually triggering again.

Reported-by: Vince Weaver <vincent.weaver@maine.edu>
Tested-by: Vince Weaver <vincent.weaver@maine.edu>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20150219170311.GH21418@twins.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

2015-05-09 23:16:31 +01:00

..

debug

kdb: fix incorrect counts in KDB summary command output

2015-05-09 23:16:19 +01:00

events

perf: Fix irq_work 'tail' recursion

2015-05-09 23:16:31 +01:00

gcov

gcov: disable CONSTRUCTORS for UML

2011-07-26 16:49:45 -07:00

irq

genirq: Prevent proc race against freeing of irq descriptors

2015-02-20 00:49:30 +00:00

power

PM / Sleep: fix recovery during resuming from hibernation

2014-12-14 16:23:52 +00:00

time

ntp: Fixup adjtimex freq validation on 32-bit systems

2015-03-06 00:39:20 +00:00

trace

ftrace: Fix ftrace enable ordering of sysctl ftrace_enabled

2015-05-09 23:16:27 +01:00

.gitignore

…

acct.c

…

async.c

Fix a dead loop in async_synchronize_full()

2012-10-10 03:31:09 +01:00

audit_tree.c

audit: keep inode pinned

2014-12-14 16:23:56 +00:00

audit_watch.c

…

audit.c

audit: use nlmsg_len() to get message payload length

2014-01-03 04:33:17 +00:00

audit.h

…

auditfilter.c

…

auditsc.c

auditsc: audit_krule mask accesses need bounds checking

2014-07-11 13:33:49 +01:00

backtracetest.c

…

bounds.c

…

capability.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

cgroup_freezer.c

cgroup: cgroup_subsys->fork() should be called after the task is added to css_set

2013-01-03 03:32:56 +00:00

cgroup.c

move d_rcu from overlapping d_child to overlapping d_alias

2015-01-01 01:27:50 +00:00

compat.c

compat: Fix RT signal mask corruption via sigprocmask

2012-05-31 00:43:51 +01:00

configs.c

kernel/configs.c: include MODULE_*() when CONFIG_IKCONFIG_PROC=n

2011-07-25 20:57:15 -07:00

cpu_pm.c

cpu_pm: call notifiers during suspend

2011-09-23 12:05:29 +05:30

cpu.c

CPU hotplug: provide a generic helper to disable/enable CPU hotplug

2013-06-19 02:16:59 +01:00

cpuset.c

cpuset,mempolicy: fix sleeping function called from invalid context

2014-08-06 18:07:33 +01:00

crash_dump.c

Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux

2011-11-06 19:44:47 -08:00

cred.c

cred: copy_process() should clear child->replacement_session_keyring

2012-04-13 08:33:50 -07:00

delayacct.c

…

dma.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

elfcore.c

…

exec_domain.c

…

exit.c

wait: fix reparent_leader() vs EXIT_DEAD->EXIT_ZOMBIE race

2014-04-30 16:23:26 +01:00

extable.c

…

fork.c

perf: fix perf bug in fork()

2014-11-05 20:27:46 +00:00

freezer.c

Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux

2011-11-06 19:44:47 -08:00

futex_compat.c

futex: Do not leak robust list to unprivileged process

2012-04-22 15:31:15 -07:00

futex.c

futex: Fix a race condition between REQUEUE_PI and task death

2014-12-14 16:23:51 +00:00

groups.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

hrtimer.c

hrtimer: Set expiry time before switch_hrtimer_base()

2014-06-09 13:29:10 +01:00

hung_task.c

hung_task: fix false positive during vfork

2012-01-03 16:14:32 -08:00

irq_work.c

kernel: fix two implicit header assumptions in irq_work.c

2011-10-31 09:20:12 -04:00

itimer.c

…

jump_label.c

jump_label: jump_label_inc may return before the code is patched

2011-12-05 13:28:46 -05:00

kallsyms.c

…

Kconfig.freezer

…

Kconfig.hz

…

Kconfig.locks

locking/mutex: Disable optimistic spinning on some architectures

2014-08-06 18:07:38 +01:00

Kconfig.preempt

…

kexec.c

[S390] kdump: Add infrastructure for unmapping crashkernel memory

2011-10-30 15:16:42 +01:00

kfifo.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

kmod.c

usermodehelper: check subprocess_info->path != NULL

2013-05-30 14:35:00 +01:00

kprobes.c

kprobes: return proper error code from register_kprobe()

2012-03-12 12:31:26 -07:00

ksysfs.c

kernel: ksysfs.c is implicitly using stat.h

2011-10-31 09:20:13 -04:00

kthread.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

latencytop.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

lockdep_internals.h

…

lockdep_proc.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

lockdep_states.h

…

lockdep.c

lockdep, kmemcheck: Annotate ->lock in lockdep_init_map()

2011-12-06 18:18:13 +01:00

Makefile

Merge branch 'devel-stable' of http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/linux-2.6-arm

2011-10-28 12:02:27 -07:00

module.c

ftrace/module: Hardcode ftrace_module_init() call into load_module()

2014-06-09 13:29:03 +01:00

mutex-debug.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

mutex-debug.h

…

mutex.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

mutex.h

…

notifier.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

nsproxy.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

padata.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

panic.c

lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging

2012-02-13 11:16:59 -08:00

params.c

kernel: params.c needs module.h not moduleparam.h

2011-10-31 09:20:13 -04:00

pid_namespace.c

…

pid.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

posix-cpu-timers.c

posix-cpu-timers: Fix nanosleep task_struct leak

2013-03-06 03:24:01 +00:00

posix-timers.c

posix-timers: Fix stack info leak in timer_create()

2014-12-14 16:23:51 +00:00

printk.c

console: Fix console name size mismatch

2015-05-09 23:16:24 +01:00

profile.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

ptrace.c

exec/ptrace: fix get_dumpable() incorrect tests

2014-01-03 04:33:21 +00:00

range.c

range: fix bogus misuse of module.h to get printk()

2011-10-31 09:20:11 -04:00

rcu.h

rcu: Add grace-period, quiescent-state, and call_rcu trace events

2011-09-28 21:38:21 -07:00

rcupdate.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

rcutiny_plugin.h

kernel: fix up module header handling in rcutiny files

2011-10-31 09:20:13 -04:00

rcutiny.c

kernel: fix up module header handling in rcutiny files

2011-10-31 09:20:13 -04:00

rcutorture.c

rcu: Make rcu_torture_boost() exit loops at end of test

2011-09-28 21:38:46 -07:00

rcutree_plugin.h

rcu: Remove rcu_needs_cpu_flush() to avoid false quiescent states

2011-09-28 21:38:48 -07:00

rcutree_trace.c

rcu: Simplify quiescent-state accounting

2011-09-28 21:38:22 -07:00

rcutree.c

rcu: Fix batch-limit size problem

2013-01-03 03:33:08 +00:00

rcutree.h

rcu: Remove rcu_needs_cpu_flush() to avoid false quiescent states

2011-09-28 21:38:48 -07:00

relay.c

splice: fix racy pipe->buffers uses

2012-07-12 04:31:59 +01:00

res_counter.c

…

resource.c

kernel/resource.c: fix stack overflow in __reserve_region_with_split()

2013-02-20 03:15:31 +00:00

rtmutex_common.h

…

rtmutex-debug.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

rtmutex-debug.h

rtmutex: Handle deadlock detection smarter

2014-07-11 13:33:50 +01:00

rtmutex-tester.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

rtmutex.c

rtmutex: Plug slow unlock race

2014-07-11 13:33:51 +01:00

rtmutex.h

rtmutex: Handle deadlock detection smarter

2014-07-11 13:33:50 +01:00

rwsem.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

sched_autogroup.c

sched/autogroup: Fix failure to set cpu.rt_runtime_us

2015-05-09 23:16:18 +01:00

sched_autogroup.h

Revert "sched, autogroup: Stop going ahead if autogroup is disabled"

2013-01-03 03:32:53 +00:00

sched_clock.c

sched_clock: Prevent 64bit inatomicity on 32bit systems

2013-04-25 20:25:34 +01:00

sched_cpupri.c

sched: Use CPUPRI_NR_PRIORITIES instead of MAX_RT_PRIO in cpupri check

2014-06-09 13:29:10 +01:00

sched_cpupri.h

sched/cpupri: Remove cpupri->pri_active

2011-08-14 12:01:11 +02:00

sched_debug.c

sched: Fix possible divide by zero in avg_atom() calculation

2014-08-06 18:07:38 +01:00

sched_fair.c

sched: Fix double normalization of vruntime

2014-04-02 00:58:56 +01:00

sched_features.h

sched, rt: Provide means of disabling cross-cpu bandwidth sharing

2011-11-14 12:50:40 +01:00

sched_idletask.c

sched/nohz: Rewrite and fix load-avg computation -- again

2012-07-25 04:11:09 +01:00

sched_rt.c

sched/rt: Reduce rq lock contention by eliminating locking of non-feasible target

2015-03-06 00:39:19 +00:00

sched_stats.h

locking, sched: Annotate thread_group_cputimer as raw

2011-09-13 11:11:55 +02:00

sched_stoptask.c

sched: Fix migration thread runtime bogosity

2012-10-17 03:50:03 +01:00

sched.c

sched/autogroup: Fix failure to set cpu.rt_runtime_us

2015-05-09 23:16:18 +01:00

seccomp.c

…

semaphore.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

signal.c

kernel/signal.c: stop info leak via the tkill and the tgkill syscalls

2013-04-25 20:25:42 +01:00

smp.c

smp: Fix SMP function call empty cpu mask race

2013-02-06 04:33:49 +00:00

softirq.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

spinlock.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

srcu.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

stacktrace.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

stop_machine.c

Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux

2011-11-06 19:44:47 -08:00

sys_ni.c

Cross Memory Attach

2011-10-31 17:30:44 -07:00

sys.c

reboot: rigrate shutdown/reboot to boot cpu

2013-06-19 02:17:00 +01:00

sysctl_binary.c

sysctl: fix null checking in bin_dn_node_address()

2013-03-06 03:24:17 +00:00

sysctl_check.c

xfs: remove subdirectories

2011-08-12 16:21:35 -05:00

sysctl.c

sysctl: fix write access to dmesg_restrict/kptr_restrict

2012-04-13 08:33:49 -07:00

taskstats.c

Make TASKSTATS require root access

2011-09-19 17:04:37 -07:00

test_kprobes.c

…

time.c

time: settimeofday: Validate the values of tv from user

2015-02-20 00:49:34 +00:00

timeconst.pl

timeconst.pl: Eliminate Perl warning

2013-03-06 03:23:52 +00:00

timer.c

timer: Prevent overflow in apply_slack

2014-06-09 13:29:04 +01:00

tracepoint.c

tracepoint: Do not waste memory on mods with no tracepoints

2014-06-09 13:28:55 +01:00

tsacct.c

Make taskstats round statistics down to nearest 1k bytes/events

2011-09-19 17:10:57 -07:00

uid16.c

…

up.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

user_namespace.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

user-return-notifier.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

user.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

utsname_sysctl.c

Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux

2011-11-06 19:44:47 -08:00

utsname.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

wait.c

kernel: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

watchdog.c

watchdog: using u64 in get_sample_period()

2012-12-06 11:20:21 +00:00

workqueue_sched.h

…

workqueue.c

workqueue: ensure @task is valid across kthread_stop()

2014-04-02 00:58:54 +01:00