openstlinux/linux-st
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
052d41c01b3a2e3371d66de569717353af489d63
linux-st/drivers/scsi
History
Linus Torvalds a817e73fe6 Revert "scsi: make 'state' device attribute pollable" 
This reverts commit 8a97712e53.

This commit added a call to sysfs_notify() from within
scsi_device_set_state(), which in turn turns out to make libata very
unhappy, because ata_eh_detach_dev() does

        spin_lock_irqsave(ap->lock, flags);
        ..
        if (ata_scsi_offline_dev(dev)) {
                dev->flags |= ATA_DFLAG_DETACHED;
                ap->pflags |= ATA_PFLAG_SCSI_HOTPLUG;
        }

and ata_scsi_offline_dev() then does that scsi_device_set_state() to set
it offline.

So now we called sysfs_notify() from within a spinlocked region, which
really doesn't work.  The 0day robot reported this as:

   BUG: sleeping function called from invalid context at kernel/locking/mutex.c:238

because sysfs_notify() ends up calling kernfs_find_and_get_ns() which
then does mutex_lock(&kernfs_mutex)..

The pollability of the device state isn't critical, so revert this all
for now, and maybe we'll do it differently in the future.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2017-11-07 09:04:32 -08:00
..
aacraid
scsi: aacraid: Fix controller initialization failure
2017-10-16 23:17:52 -04:00
aic7xxx
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
aic94xx
scsi: libsas: move bus_reset_handler() to target_reset_handler()
2017-08-25 17:21:10 -04:00
arcmsr
…
arm
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
be2iscsi
…
bfa
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
bnx2fc
Merge branch 'fixes' into misc
2017-09-07 12:12:43 -07:00
bnx2i
…
csiostor
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
cxgbi
Merge branch 'fixes' into misc
2017-09-07 12:12:43 -07:00
cxlflash
scsi: cxlflash: Fix vlun resize failure in the shrink path
2017-08-25 18:24:04 -04:00
device_handler
…
dpt
…
esas2r
…
fcoe
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fnic
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
hisi_sas
scsi: libsas: move bus_reset_handler() to target_reset_handler()
2017-08-25 17:21:10 -04:00
ibmvscsi
scsi: ibmvfc: ibmvscsi: ibmvscsi_tgt: constify vio_device_id
2017-08-25 17:42:42 -04:00
ibmvscsi_tgt
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
isci
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
libfc
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
libsas
scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough
2017-08-29 21:51:45 -04:00
lpfc
Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
2017-09-30 12:50:56 -07:00
megaraid
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mpt3sas
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mvsas
scsi: libsas: move bus_reset_handler() to target_reset_handler()
2017-08-25 17:21:10 -04:00
osd
…
pcmcia
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
pm8001
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
qedf
Merge branch 'fixes' into misc
2017-09-07 12:12:43 -07:00
qedi
Merge branch 'fixes' into misc
2017-09-07 12:12:43 -07:00
qla2xxx
Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
2017-11-03 10:26:40 -07:00
qla4xxx
…
smartpqi
scsi: smartpqi: remove the smp_handler stub
2017-08-29 21:51:44 -04:00
snic
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sym53c8xx_2
drivers/scsi/sym53c8xx_2/sym_hipd.c: convert to use memset32
2017-09-08 18:26:48 -07:00
ufs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
.gitignore
…
3w-9xxx.c
…
3w-9xxx.h
…
3w-sas.c
…
3w-sas.h
…
3w-xxxx.c
…
3w-xxxx.h
…
53c700_d.h_shipped
…
53c700.c
scsi: 53c700: move bus reset to host reset
2017-08-25 17:21:11 -04:00
53c700.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
53c700.scr
…
a100u2w.c
…
a100u2w.h
…
a2091.c
scsi: drop bus reset for wd33c93-compatible boards
2017-08-25 17:21:10 -04:00
a2091.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
a3000.c
scsi: drop bus reset for wd33c93-compatible boards
2017-08-25 17:21:10 -04:00
a3000.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
a4000t.c
…
advansys.c
…
aha152x.c
scsi: aha152x: drop host reset
2017-08-25 17:21:11 -04:00
aha152x.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
aha1542.c
…
aha1542.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
aha1740.c
…
aha1740.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
am53c974.c
…
atari_scsi.c
scsi: NCR5380: Move bus reset to host reset
2017-08-25 17:21:11 -04:00
atp870u.c
…
atp870u.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
BusLogic.c
…
BusLogic.h
…
bvme6000_scsi.c
…
ch.c
…
constants.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dc395x.c
…
dc395x.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dmx3191d.c
scsi: NCR5380: Move bus reset to host reset
2017-08-25 17:21:11 -04:00
dpt_i2o.c
…
dpti.h
…
eata_generic.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
eata_pio.c
…
eata_pio.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
eata.c
scsi: eata: remove 'arg_done' from eata2x_eh_host_reset()
2017-08-25 17:21:12 -04:00
esp_scsi.c
…
esp_scsi.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fdomain.c
scsi: fdomain: move bus reset to host reset
2017-08-25 17:21:10 -04:00
fdomain.h
scsi: fdomain: move bus reset to host reset
2017-08-25 17:21:10 -04:00
FlashPoint.c
…
g_NCR5380.c
scsi: NCR5380: Move bus reset to host reset
2017-08-25 17:21:11 -04:00
gdth_ioctl.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
gdth_proc.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
gdth_proc.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
gdth.c
…
gdth.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
gvp11.c
scsi: drop bus reset for wd33c93-compatible boards
2017-08-25 17:21:10 -04:00
gvp11.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
hosts.c
scsi: Remove Scsi_Host.uspace_req_q
2017-09-05 08:18:42 -04:00
hpsa_cmd.h
…
hpsa.c
scsi: hpsa: Fix configured_logical_drive_count·check
2017-10-16 23:14:31 -04:00
hpsa.h
…
hptiop.c
scsi: hptiop: Simplify reset handling
2017-08-25 17:21:10 -04:00
hptiop.h
…
imm.c
scsi: imm: drop duplicate bus_reset handler
2017-08-25 17:21:11 -04:00
imm.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
initio.c
…
initio.h
…
ipr.c
…
ipr.h
…
ips.c
…
ips.h
…
iscsi_boot_sysfs.c
…
iscsi_tcp.c
scsi: iscsi_tcp: Remove a set-but-not-used variable
2017-08-25 17:08:08 -04:00
iscsi_tcp.h
…
jazz_esp.c
…
Kconfig
Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
2017-09-13 10:47:14 -07:00
lasi700.c
…
libiscsi_tcp.c
…
libiscsi.c
scsi: libiscsi: fix shifting of DID_REQUEUE host byte
2017-10-11 13:32:35 -04:00
mac53c94.c
…
mac53c94.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mac_esp.c
…
mac_scsi.c
scsi: NCR5380: Move bus reset to host reset
2017-08-25 17:21:11 -04:00
Makefile
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
megaraid.c
…
megaraid.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mesh.c
…
mesh.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mvme16x_scsi.c
…
mvme147.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mvme147.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mvumi.c
…
mvumi.h
…
ncr53c8xx.c
…
ncr53c8xx.h
…
NCR53c406a.c
…
NCR5380.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
NCR5380.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
NCR_D700.c
…
NCR_D700.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
NCR_Q720.c
dma-coherent: remove the DMA_MEMORY_MAP and DMA_MEMORY_IO flags
2017-09-01 11:59:17 +02:00
NCR_Q720.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
nsp32_debug.c
…
nsp32_io.h
…
nsp32.c
scsi: nsp32: drop bus reset
2017-08-25 17:21:11 -04:00
nsp32.h
…
osst_detect.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
osst_options.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
osst.c
…
osst.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
pmcraid.c
…
pmcraid.h
…
ppa.c
scsi: ppa: drop duplicate bus_reset handler
2017-08-25 17:21:11 -04:00
ppa.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ps3rom.c
…
qla1280.c
…
qla1280.h
…
qlogicfas408.c
scsi: qlogicfas: move bus_reset to host_reset
2017-08-25 17:21:11 -04:00
qlogicfas408.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
qlogicfas.c
scsi: qlogicfas: move bus_reset to host_reset
2017-08-25 17:21:11 -04:00
qlogicpti.c
scsi: qlogicpti: fixup qlogicpti_reset() definition
2017-08-28 22:15:46 -04:00
qlogicpti.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
raid_class.c
…
script_asm.pl
…
scsi_common.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_debug.c
treewide: make "nr_cpu_ids" unsigned
2017-09-08 18:26:48 -07:00
scsi_debugfs.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_debugfs.h
…
scsi_devinfo.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_dh.c
…
scsi_error.c
scsi: ILLEGAL REQUEST + ASC==27 => target failure
2017-09-27 21:55:21 -04:00
scsi_ioctl.c
scsi: Suppress gcc 7 fall-through warnings reported with W=1
2017-08-25 17:08:07 -04:00
scsi_lib_dma.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_lib.c
Revert "scsi: make 'state' device attribute pollable"
2017-11-07 09:04:32 -08:00
scsi_logging.c
…
scsi_logging.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_module.c
…
scsi_netlink.c
…
scsi_pm.c
…
scsi_priv.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_proc.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_sas_internal.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_scan.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_sysctl.c
…
scsi_sysfs.c
scsi: fixup kernel warning during rmmod()
2017-10-06 14:48:55 -04:00
scsi_trace.c
…
scsi_transport_api.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsi_transport_fc.c
scsi: fc: check for rport presence in fc_block_scsi_eh
2017-10-11 14:33:12 -04:00
scsi_transport_iscsi.c
scsi: libiscsi: Remove iscsi_destroy_session
2017-10-02 22:23:21 -04:00
scsi_transport_sas.c
scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough
2017-08-29 21:51:45 -04:00
scsi_transport_spi.c
…
scsi_transport_srp.c
Revert "scsi: make 'state' device attribute pollable"
2017-11-07 09:04:32 -08:00
scsi_typedefs.h
…
scsi.c
Merge branch 'fixes' into misc
2017-09-07 12:12:43 -07:00
scsi.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
scsicam.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sd_dif.c
…
sd_zbc.c
…
sd.c
scsi: sd: Do not override max_sectors_kb sysfs setting
2017-10-02 22:16:25 -04:00
sd.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sense_codes.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ses.c
Merge branch 'fixes' into misc
2017-09-07 12:12:43 -07:00
sg.c
scsi: sg: Re-fix off by one in sg_fill_request_table()
2017-10-17 22:41:11 -04:00
sgiwd93.c
scsi: drop bus reset for wd33c93-compatible boards
2017-08-25 17:21:10 -04:00
sim710.c
…
sni_53c710.c
…
sr_ioctl.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sr_vendor.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sr.c
scsi: sd: sr: Convert two assignments into warning statements
2017-08-25 17:08:08 -04:00
sr.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
st_options.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
st.c
…
st.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
stex.c
…
storvsc_drv.c
scsi: storvsc: fix memory leak on ring buffer busy
2017-08-30 21:53:13 -04:00
sun3_scsi_vme.c
…
sun3_scsi.c
scsi: NCR5380: Move bus reset to host reset
2017-08-25 17:21:11 -04:00
sun3x_esp.c
…
sun_esp.c
…
sym53c416.c
…
sym53c416.h
…
virtio_scsi.c
…
vmw_pvscsi.c
…
vmw_pvscsi.h
…
wd33c93.c
scsi: drop bus reset for wd33c93-compatible boards
2017-08-25 17:21:10 -04:00
wd33c93.h
…
wd719x.c
…
wd719x.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xen-scsifront.c
…
zalon.c
…
zorro7xx.c
…