Nikanth Karthikesan
316d315bff
block: Seperate read and write statistics of in_flight requests v2
...
Commit a9327cac44 added seperate read
and write statistics of in_flight requests. And exported the number
of read and write requests in progress seperately through sysfs.
But Corrado Zoccolo <czoccolo@gmail.com > reported getting strange
output from "iostat -kx 2". Global values for service time and
utilization were garbage. For interval values, utilization was always
100%, and service time is higher than normal.
So this was reverted by commit 0f78ab9899
The problem was in part_round_stats_single(), I missed the following:
if (now == part->stamp)
return;
- if (part->in_flight) {
+ if (part_in_flight(part)) {
__part_stat_add(cpu, part, time_in_queue,
part_in_flight(part) * (now - part->stamp));
__part_stat_add(cpu, part, io_ticks, (now - part->stamp));
With this chunk included, the reported regression gets fixed.
Signed-off-by: Nikanth Karthikesan <knikanth@suse.de >
--
Signed-off-by: Jens Axboe <jens.axboe@oracle.com >
2009-10-06 20:16:55 +02:00
..
2009-09-22 20:49:04 +01:00
2009-09-19 00:51:34 -03:00
2009-09-23 15:39:36 -07:00
2009-09-22 07:54:33 -07:00
2009-09-26 10:50:47 -07:00
2009-09-23 07:39:38 -07:00
2009-09-20 05:55:36 -07:00
2009-09-23 07:39:29 -07:00
2009-09-22 13:32:45 +01:00
2009-09-26 10:49:42 -07:00
2009-09-23 14:36:38 -04:00
2009-09-24 07:21:05 -07:00
2009-09-24 15:13:11 -07:00
2009-09-19 02:14:45 -04:00
2009-09-27 11:39:25 -07:00
2009-09-20 16:09:20 +05:30
2009-09-23 07:39:29 -07:00
2009-09-30 16:12:20 -07:00
2009-09-26 00:10:40 +02:00
2009-09-21 21:03:58 +01:00
2009-09-24 07:21:01 -07:00
2009-10-05 11:03:58 +02:00
2009-10-01 21:19:34 +02:00
2009-09-22 07:17:38 -07:00
2009-09-21 15:14:51 +02:00
2009-10-01 16:11:11 -07:00
2009-09-23 07:39:29 -07:00
2009-09-24 07:20:57 -07:00
2009-10-02 10:54:05 -07:00
2009-09-24 09:34:53 +09:30
2009-09-23 11:01:25 -07:00
2009-09-19 13:13:31 -07:00
2009-09-24 07:20:57 -07:00
2009-09-19 12:50:38 -07:00
2009-09-23 07:39:29 -07:00
2009-09-22 07:17:47 -07:00
2009-10-04 12:39:14 -07:00
2009-09-24 07:21:04 -07:00
2009-09-24 07:21:04 -07:00
2009-10-06 20:16:55 +02:00
2009-09-23 07:39:29 -07:00
2009-09-23 07:39:46 -07:00
2009-09-19 13:13:31 -07:00
2009-09-27 11:39:25 -07:00
2009-09-26 20:28:07 -07:00
2009-09-21 14:28:04 +02:00
2009-09-24 09:34:38 +09:30
2009-09-23 07:39:41 -07:00
2009-09-26 10:17:19 -07:00
2009-09-30 00:32:06 -04:00
2009-09-23 07:39:58 -07:00
2009-09-23 07:39:30 -07:00
2009-09-19 13:13:17 -07:00
2009-09-23 07:39:29 -07:00
2009-09-26 10:17:19 -07:00
2009-09-22 07:17:33 -07:00
2009-09-21 06:27:08 +02:00
2009-09-22 07:17:48 -07:00
2009-09-23 07:39:42 -07:00
2009-09-24 07:20:59 -07:00
2009-09-23 07:39:41 -07:00
2009-09-22 07:17:35 -07:00
2009-09-19 12:50:38 -07:00
2009-09-21 15:14:56 +02:00
2009-09-22 07:17:37 -07:00
2009-09-27 11:39:25 -07:00
2009-09-24 17:20:20 -07:00
2009-09-22 07:17:42 -07:00
2009-09-22 07:17:31 -07:00
2009-09-24 07:21:04 -07:00
2009-09-23 07:39:43 -07:00
2009-09-25 00:32:58 +09:30
2009-09-30 16:12:20 -07:00
2009-09-30 16:12:20 -07:00
2009-09-21 15:14:51 +02:00
2009-09-30 16:12:20 -07:00
2009-09-30 16:12:20 -07:00
2009-09-24 15:44:05 -07:00
2009-09-22 07:54:33 -07:00
2009-09-26 10:17:19 -07:00
2009-09-22 07:17:38 -07:00
2009-09-24 07:20:58 -07:00
2009-09-24 07:53:22 -07:00
2009-09-24 07:55:29 -07:00
2009-09-22 15:42:01 +02:00
2009-09-22 15:42:01 +02:00
2009-09-24 15:38:57 -07:00
2009-09-22 07:17:49 -07:00
2009-09-22 07:17:47 -07:00
2009-10-04 15:05:10 -07:00
2009-09-24 07:53:22 -07:00
2009-09-23 07:39:41 -07:00
2009-09-22 07:17:24 -07:00
2009-09-27 11:39:25 -07:00
2009-09-19 08:53:22 +02:00
2009-09-19 08:53:22 +02:00
2009-09-19 08:53:22 +02:00
2009-09-24 07:20:57 -07:00
2009-10-01 16:11:13 -07:00
2009-09-24 07:53:22 -07:00
2009-09-24 07:53:22 -07:00
2009-09-24 07:21:04 -07:00
2009-09-24 07:47:35 -04:00
2009-09-19 13:13:19 -07:00
2009-09-30 21:46:59 +02:00
2009-09-19 13:13:30 -07:00
2009-09-24 07:21:01 -07:00
2009-09-24 09:34:40 +09:30
2009-09-24 07:53:22 -07:00
2009-09-23 09:21:05 -07:00
2009-09-24 07:21:04 -07:00
2009-09-24 07:20:56 -07:00
2009-09-24 09:34:41 +09:30
2009-09-24 07:21:00 -07:00
2009-09-24 07:20:57 -07:00
2009-09-27 13:35:16 -07:00
2009-09-19 13:13:35 -07:00
2009-09-23 07:39:48 -07:00
2009-09-23 06:46:23 -07:00
2009-09-23 06:46:39 -07:00
2009-09-23 18:13:10 -07:00
2009-09-24 09:57:08 -07:00
2009-09-23 22:26:32 +09:30
2009-09-23 22:26:32 +09:30
2009-09-23 22:26:36 +09:30
2009-09-23 07:39:29 -07:00
2009-09-23 22:26:32 +09:30
2009-09-23 22:26:32 +09:30
2009-09-23 22:26:32 +09:30
2009-09-23 22:26:32 +09:30
2009-09-23 22:26:31 +09:30
2009-09-22 07:17:30 -07:00
2009-09-19 13:13:25 -07:00
2009-09-19 13:13:26 -07:00
2009-09-23 03:49:27 +04:00
2009-09-21 15:14:53 +02:00
2009-09-24 07:21:04 -07:00