Zheng Yejian 3caa693781 ftrace: Fix issue that 'direct->addr' not restored in modify_ftrace_direct() ...

commit 2a2d8c51defb446e8d89a83f42f8e5cd529111e9 upstream.

Syzkaller report a WARNING: "WARN_ON(!direct)" in modify_ftrace_direct().

Root cause is 'direct->addr' was changed from 'old_addr' to 'new_addr' but
not restored if error happened on calling ftrace_modify_direct_caller().
Then it can no longer find 'direct' by that 'old_addr'.

To fix it, restore 'direct->addr' to 'old_addr' explicitly in error path.

Link: https://lore.kernel.org/linux-trace-kernel/20230330025223.1046087-1-zhengyejian1@huawei.com

Cc: stable@vger.kernel.org
Cc: <mhiramat@kernel.org>
Cc: <mark.rutland@arm.com>
Cc: <ast@kernel.org>
Cc: <daniel@iogearbox.net>
Fixes: 8a141dd7f7 ("ftrace: Fix modify_ftrace_direct.")
Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2023-04-13 16:55:32 +02:00

..

rv

rv/monitor: Add __init/__exit annotations to module init/exit funcs

2022-09-26 18:10:51 -04:00

blktrace.c

trace/blktrace: fix memory leak with using debugfs_lookup()

2023-03-10 09:33:46 +01:00

bpf_trace.c

bpf: Fix a possible task gone issue with bpf_send_signal[_thread]() helpers

2023-02-09 11:28:00 +01:00

bpf_trace.h

…

error_report-traces.c

…

fgraph.c

…

fprobe.c

tracing/fprobe: Fix to check whether fprobe is registered correctly

2022-11-04 08:50:07 +09:00

ftrace_internal.h

…

ftrace.c

ftrace: Fix issue that 'direct->addr' not restored in modify_ftrace_direct()

2023-04-13 16:55:32 +02:00

Kconfig

tracing: Fix complicated dependency of CONFIG_TRACER_MAX_TRACE

2023-01-07 11:11:48 +01:00

kprobe_event_gen_test.c

tracing: Fix wrong return in kprobe_event_gen_test.c

2023-04-06 12:10:41 +02:00

Makefile

…

pid_list.c

…

pid_list.h

…

power-traces.c

…

preemptirq_delay_test.c

…

rethook.c

rethook: fix a potential memleak in rethook_alloc()

2022-11-18 10:15:34 +09:00

ring_buffer_benchmark.c

…

ring_buffer.c

tracing: Add NULL checks for buffer in ring_buffer_free_read_page()

2023-03-11 13:55:32 +01:00

rpm-traces.c

…

synth_event_gen_test.c

tracing: Fix memory leak in test_gen_synth_cmd() and test_empty_synth_event()

2022-11-17 17:51:38 -05:00

trace_benchmark.c

tracing: Add numeric delta time to the trace event benchmark

2022-09-26 13:01:09 -04:00

trace_benchmark.h

tracing: Add numeric delta time to the trace event benchmark

2022-09-26 13:01:09 -04:00

trace_boot.c

…

trace_branch.c

…

trace_clock.c

…

trace_dynevent.c

tracing: Free buffers when a used dynamic event is removed

2022-11-23 19:07:12 -05:00

trace_dynevent.h

…

trace_entries.h

…

trace_eprobe.c

tracing: Fix race where eprobes can be called before the event

2023-01-07 11:11:48 +01:00

trace_event_perf.c

…

trace_events_filter_test.h

…

trace_events_filter.c

tracing/filter: Call filter predicate functions directly via a switch statement

2022-09-26 13:01:10 -04:00

trace_events_hist.c

tracing: Do not let histogram values have some modifiers

2023-04-06 12:10:36 +02:00

trace_events_inject.c

…

trace_events_synth.c

tracing: Fix issue of missing one synthetic field

2023-01-07 11:11:48 +01:00

trace_events_trigger.c

…

trace_events_user.c

use less confusing names for iov_iter direction initializers

2023-02-09 11:28:04 +01:00

trace_events.c

tracing: Make trace_define_field_ext() static

2023-02-22 12:59:53 +01:00

trace_export.c

tracing: Fix TASK_COMM_LEN in trace event format file

2023-02-14 19:11:54 +01:00

trace_functions_graph.c

…

trace_functions.c

…

trace_hwlat.c

tracing/hwlat: Replace sched_setaffinity with set_cpus_allowed_ptr

2023-03-30 12:48:59 +02:00

trace_irqsoff.c

…

trace_kdb.c

…

trace_kprobe_selftest.c

…

trace_kprobe_selftest.h

…

trace_kprobe.c

tracing: Move duplicate code of trace_kprobe/eprobe.c into header

2022-10-12 13:50:00 -04:00

trace_mmiotrace.c

…

trace_nop.c

…

trace_osnoise.c

tracing/osnoise: Use built-in RCU list checking

2023-02-01 08:34:46 +01:00

trace_output.c

tracing: Make sure trace_printk() can output as soon as it can be used

2023-02-01 08:34:37 +01:00

trace_output.h

…

trace_preemptirq.c

…

trace_printk.c

…

trace_probe_kernel.h

tracing: Add "(fault)" name injection to kernel probes

2022-10-12 13:50:20 -04:00

trace_probe_tmpl.h

…

trace_probe.c

tracing/probes: Handle system names with hyphens

2023-01-07 11:11:48 +01:00

trace_probe.h

tracing/eprobe: Add eprobe filter support

2022-09-26 13:01:08 -04:00

trace_recursion_record.c

…

trace_sched_switch.c

…

trace_sched_wakeup.c

…

trace_selftest_dynamic.c

…

trace_selftest.c

…

trace_seq.c

…

trace_stack.c

…

trace_stat.c

…

trace_stat.h

…

trace_synth.h

…

trace_syscalls.c

tracing: Remove unused __bad_type_size() method

2022-11-17 20:21:06 -05:00

trace_uprobe.c

…

trace.c

tracing: Add .graph suffix option to histogram value

2023-04-06 12:10:36 +02:00

trace.h

tracing: Fix TASK_COMM_LEN in trace event format file

2023-02-14 19:11:54 +01:00

tracing_map.c

tracing: Remove unused variable 'dups'

2022-10-03 12:20:31 -04:00

tracing_map.h

…