David Gibson 9da61aef0f
[PATCH] hugepage: Fix hugepage logic in free_pgtables() ...
free_pgtables() has special logic to call hugetlb_free_pgd_range() instead
of the normal free_pgd_range() on hugepage VMAs. However, the test it uses
to do so is incorrect: it calls is_hugepage_only_range on a hugepage sized
range at the start of the vma. is_hugepage_only_range() will return true
if the given range has any intersection with a hugepage address region, and
in this case the given region need not be hugepage aligned. So, for
example, this test can return true if called on, say, a 4k VMA immediately
preceding a (nicely aligned) hugepage VMA.
At present we get away with this because the powerpc version of
hugetlb_free_pgd_range() is just a call to free_pgd_range(). On ia64 (the
only other arch with a non-trivial is_hugepage_only_range()) we get away
with it for a different reason; the hugepage area is not contiguous with
the rest of the user address space, and VMAs are not permitted in between,
so the test can't return a false positive there.
Nonetheless this should be fixed. We do that in the patch below by
replacing the is_hugepage_only_range() test with an explicit test of the
VMA using is_vm_hugetlb_page().
This in turn changes behaviour for platforms where is_hugepage_only_range()
returns false always (everything except powerpc and ia64). We address this
by ensuring that hugetlb_free_pgd_range() is defined to be identical to
free_pgd_range() (instead of a no-op) on everything except ia64. Even so,
it will prevent some otherwise possible coalescing of calls down to
free_pgd_range(). Since this only happens for hugepage VMAs, removing this
small optimization seems unlikely to cause any trouble.
This patch causes no regressions on the libhugetlbfs testsuite - ppc64
POWER5 (8-way), ppc64 G5 (2-way) and i386 Pentium M (UP).
Signed-off-by: David Gibson <dwg@au1.ibm.com >
Cc: William Lee Irwin III <wli@holomorphy.com >
Acked-by: Hugh Dickins <hugh@veritas.com >
Signed-off-by: Andrew Morton <akpm@osdl.org >
Signed-off-by: Linus Torvalds <torvalds@osdl.org >
2006-03-22 07:54:03 -08:00
2006-03-16 14:10:19 +00:00
2006-01-08 20:14:02 -08:00
2006-03-21 08:52:18 -08:00
2006-02-14 16:09:34 -08:00
2006-02-22 09:32:46 +00:00
2006-02-07 20:56:35 -05:00
2006-03-20 18:03:59 -08:00
2006-01-12 14:06:43 -08:00
2006-02-27 13:04:17 -08:00
2006-03-20 23:41:17 -08:00
2006-03-20 18:03:40 -08:00
2006-01-18 19:20:24 -08:00
2006-01-06 08:34:10 -08:00
2006-01-13 16:29:56 -08:00
2006-03-20 22:35:41 -08:00
2005-11-13 18:14:17 -08:00
2006-02-20 20:00:10 -08:00
2006-01-16 20:53:46 -08:00
2006-01-08 20:14:03 -08:00
2006-01-17 08:38:12 -05:00
2006-02-12 14:24:41 -05:00
2006-01-08 20:14:07 -08:00
2005-11-29 16:16:41 -08:00
2006-01-13 09:12:21 -08:00
2005-12-14 19:03:35 -08:00
2005-10-30 17:37:21 -08:00
2006-02-03 08:32:00 -08:00
2006-03-18 18:34:37 -05:00
2006-01-06 08:33:26 -08:00
2006-01-08 20:13:47 -08:00
2006-01-10 20:35:03 -05:00
2006-01-10 08:01:35 -08:00
2006-01-11 18:42:13 -08:00
2005-11-18 22:00:17 +01:00
2006-01-07 16:15:52 +00:00
2005-11-13 18:14:10 -08:00
2005-12-12 08:57:42 -08:00
2006-03-09 19:47:37 -08:00
2006-02-11 21:41:11 -08:00
2006-01-14 18:27:15 -08:00
2006-01-14 18:27:16 -08:00
2006-01-10 08:32:35 -08:00
2006-01-08 20:14:02 -08:00
2005-11-06 10:22:04 +01:00
2006-02-03 14:01:05 -08:00
2005-11-10 15:33:38 -08:00
2005-11-07 07:53:52 -08:00
2006-03-20 13:42:59 -08:00
2006-01-18 13:53:45 -08:00
2006-02-10 08:13:12 -08:00
2006-01-14 18:27:10 -08:00
2006-03-21 20:14:08 +11:00
2006-01-08 20:14:07 -08:00
2006-02-07 20:56:35 -05:00
2006-03-20 22:50:58 -08:00
2006-03-20 13:42:59 -08:00
2006-02-01 08:53:11 -08:00
2006-03-20 13:42:59 -08:00
2006-01-06 08:34:01 -08:00
2006-01-11 19:04:51 -08:00
2006-03-20 22:42:39 -08:00
2005-11-03 13:53:34 +11:00
2005-11-17 16:23:43 +00:00
2005-11-17 16:23:42 +00:00
2006-03-18 22:27:18 -05:00
2006-01-08 20:13:49 -08:00
2006-02-03 08:32:09 -08:00
2006-01-03 15:25:45 -08:00
2005-11-05 21:00:02 -05:00
2006-01-09 15:59:24 -08:00
2006-01-14 18:27:15 -08:00
2006-01-18 19:20:29 -08:00
2006-03-08 14:14:01 -08:00
2006-01-06 13:08:20 -08:00
2006-01-04 16:18:08 -08:00
2005-11-12 10:14:02 -08:00
2005-11-09 07:55:57 -08:00
2006-03-11 09:19:34 -08:00
2006-03-20 14:49:55 -08:00
2006-02-01 08:53:09 -08:00
2005-10-30 17:37:32 -08:00
2005-11-10 02:26:41 +01:00
2005-11-12 10:55:21 +01:00
2006-03-09 19:47:38 -08:00
2006-01-14 18:27:09 -08:00
2005-11-19 22:17:55 +01:00
2006-03-06 18:40:44 -08:00
2006-03-22 07:54:03 -08:00
2006-01-05 22:16:26 -08:00
2006-01-15 09:02:44 -02:00
2006-02-06 12:02:14 -08:00
2006-02-03 08:32:07 -08:00
2006-03-20 17:04:53 -08:00
2006-02-03 08:32:12 -08:00
2005-11-08 17:14:08 +01:00
2006-03-03 20:58:00 -05:00
2006-01-08 20:14:07 -08:00
2005-11-08 09:40:47 -08:00
2006-01-03 13:11:23 -08:00
2005-11-09 07:55:57 -08:00
2006-03-20 17:09:11 -08:00
2006-03-20 22:41:23 -08:00
2006-01-06 13:24:54 -08:00
2006-03-20 22:39:47 -08:00
2005-11-13 18:14:16 -08:00
2006-01-16 23:18:35 -08:00
2005-12-12 08:57:43 -08:00
2006-01-04 16:18:09 -08:00
2006-01-09 16:03:03 +01:00
2006-02-01 08:53:13 -08:00
2006-02-08 01:03:52 -05:00
2005-11-07 07:54:07 -08:00
2006-01-06 13:24:29 -08:00
2005-11-07 07:53:43 -08:00
2006-03-20 17:06:24 -08:00
2006-03-20 17:07:03 -08:00
2006-03-20 22:21:10 -08:00
2006-01-06 08:33:53 -08:00
2006-01-08 20:14:07 -08:00
2006-01-10 08:02:01 -08:00
2005-11-09 07:55:57 -08:00
2006-02-14 16:09:34 -08:00
2006-01-09 15:59:24 -08:00
2005-11-07 14:18:56 +01:00
2005-11-07 14:18:56 +01:00
2006-01-10 08:01:35 -08:00
2006-02-10 08:13:12 -08:00
2005-11-07 07:53:37 -08:00
2006-02-17 08:00:40 -08:00
2006-02-10 08:13:12 -08:00
2005-10-30 17:37:23 -08:00
2006-01-08 20:13:53 -08:00
2006-01-08 20:13:53 -08:00
2006-03-06 18:40:44 -08:00
2006-03-20 13:42:58 -08:00
2006-03-20 13:42:59 -08:00
2006-01-11 18:42:12 -08:00
2005-10-30 17:37:17 -08:00
2006-02-15 15:32:22 -08:00
2006-03-11 19:03:38 -05:00
2006-03-20 17:19:17 -08:00
2006-01-09 15:59:27 -08:00
2006-03-06 18:40:44 -08:00
2006-01-08 20:12:39 -08:00
2006-01-18 19:20:18 -08:00
2006-03-22 07:53:57 -08:00
2006-03-22 07:54:02 -08:00
2006-02-01 08:53:15 -08:00
2006-03-20 13:42:58 -08:00
2006-01-06 21:17:50 +01:00
2006-01-10 08:01:34 -08:00
2006-01-08 20:13:46 -08:00
2006-01-11 08:14:16 -08:00
2006-01-11 08:14:16 -08:00
2006-01-27 11:11:16 -05:00
2005-12-24 15:37:00 -08:00
2006-01-18 19:20:29 -08:00
2006-02-07 16:12:34 -08:00
2006-01-06 08:33:20 -08:00
2006-01-14 18:27:12 -08:00
2006-01-08 20:14:07 -08:00
2006-03-20 22:45:21 -08:00
2006-03-20 22:32:28 -08:00
2006-03-20 22:58:21 -08:00
2006-02-15 01:34:23 -08:00
2006-01-10 12:54:29 -08:00
2006-03-20 22:45:21 -08:00
2006-03-20 18:52:01 -08:00
2006-02-20 20:00:11 -08:00
2006-01-06 14:58:58 -05:00
2006-01-06 14:58:48 -05:00
2006-01-06 14:58:51 -05:00
2006-02-07 20:56:35 -05:00
2006-03-22 07:53:58 -08:00
2005-11-13 18:14:12 -08:00
2006-01-08 20:13:52 -08:00
2006-01-06 08:33:58 -08:00
2006-02-03 08:32:05 -08:00
2006-03-20 22:27:35 -08:00
2006-01-09 15:03:17 +11:00
2005-11-10 16:09:15 -08:00
2006-01-31 18:00:11 -08:00
2006-03-08 14:14:01 -08:00
2006-01-08 20:13:59 -08:00
2006-01-15 02:12:54 +01:00
2005-11-09 07:55:57 -08:00
2006-01-12 16:31:52 -05:00
2006-01-09 15:59:24 -08:00
2006-01-03 13:11:05 -08:00
2006-02-05 11:06:52 -08:00
2006-01-04 16:18:09 -08:00
2005-11-13 18:14:10 -08:00
2005-11-13 18:14:10 -08:00
2006-01-09 15:47:16 +11:00
2006-01-03 12:31:30 +01:00
2006-01-18 19:20:30 -08:00
2006-02-01 08:53:13 -08:00
2005-11-08 09:40:47 -08:00
2005-12-22 09:17:39 -08:00
2006-01-13 21:02:13 +11:00
2006-02-15 11:05:43 -08:00
2005-11-07 18:18:09 -08:00
2006-02-03 08:32:08 -08:00
2006-01-08 20:13:48 -08:00
2006-01-12 11:35:15 -06:00
2006-01-06 08:33:32 -08:00
2006-01-03 13:10:56 -08:00
2006-03-08 14:14:01 -08:00
2005-12-15 13:28:14 -05:00
2006-02-05 11:06:52 -08:00
2006-02-01 08:53:25 -08:00
2006-03-02 10:37:59 -08:00
2006-02-01 08:53:25 -08:00
2006-01-08 20:13:51 -08:00
2006-01-10 08:01:53 -08:00
2005-11-07 07:53:46 -08:00
2005-11-07 07:53:46 -08:00
2005-11-07 07:53:47 -08:00
2006-02-01 08:53:16 -08:00
2005-11-07 14:25:38 +01:00
2006-03-22 07:53:55 -08:00
2006-03-20 22:26:17 -08:00
2006-03-11 09:19:34 -08:00
2006-01-10 08:01:42 -08:00
2006-01-08 20:14:07 -08:00
2006-01-08 20:14:02 -08:00
2006-03-20 22:41:23 -08:00
2005-11-07 07:53:41 -08:00
2006-01-21 23:03:28 +00:00
2006-03-20 01:12:18 -08:00
2006-02-23 09:49:35 +00:00
2005-10-30 17:37:32 -08:00
2005-11-07 07:53:37 -08:00
2006-01-14 18:27:07 -08:00
2006-01-08 20:13:53 -08:00
2006-03-20 22:43:56 -08:00
2006-03-22 07:53:59 -08:00
2006-01-14 18:27:13 -08:00
2005-11-13 18:14:13 -08:00
2006-03-22 07:53:59 -08:00
2006-03-20 22:41:23 -08:00
2006-01-08 20:14:02 -08:00
2005-12-26 00:33:41 +01:00
2005-11-09 07:55:57 -08:00
2005-11-07 07:53:28 -08:00
2006-02-07 16:12:33 -08:00
2006-03-22 07:54:00 -08:00
2006-01-08 20:13:45 -08:00
2006-02-24 14:31:39 -08:00
2006-03-20 22:40:29 -08:00
2006-03-20 21:32:58 -08:00
2005-10-30 17:37:32 -08:00
2005-11-13 18:14:14 -08:00
2006-02-11 21:41:11 -08:00
2006-01-10 08:01:38 -08:00
2006-02-17 08:24:29 -08:00
2006-01-18 00:45:15 +01:00
2006-01-12 14:06:38 -08:00
2006-01-18 19:20:17 -08:00
2006-02-10 08:13:12 -08:00
2006-01-10 08:01:59 -08:00
2006-02-10 08:13:12 -08:00
2006-02-01 08:53:13 -08:00
2006-01-03 13:19:13 +01:00
2006-01-03 13:19:13 +01:00
2006-01-03 13:19:13 +01:00
2006-01-03 13:11:21 -08:00
2006-02-03 08:32:04 -08:00
2006-02-03 08:32:05 -08:00
2005-11-20 00:51:33 -05:00
2006-01-31 17:23:44 -08:00
2006-03-20 14:49:58 -08:00
2006-01-04 13:51:42 -08:00
2006-03-20 14:49:54 -08:00
2006-01-09 15:32:31 -02:00
2006-03-21 08:52:18 -08:00
2005-11-09 07:56:23 -08:00
2005-11-07 07:53:41 -08:00
2006-01-08 20:14:07 -08:00
2006-01-08 20:12:40 -08:00
2006-01-08 20:13:47 -08:00
2006-01-10 08:01:29 -08:00
2006-03-20 21:25:50 -08:00
2006-01-10 08:01:57 -08:00
9da61aef0f