openstlinux/linux-st
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
aa40d5a43526cca9439a2b45fcfdcd016594dece
linux-st/net/mac80211
History
Tetsuo Handa aa40d5a435 wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop() 
lockdep complains use of uninitialized spinlock at ieee80211_do_stop() [1],
for commit f856373e2f ("wifi: mac80211: do not wake queues on a vif
that is being stopped") guards clear_bit() using fq.lock even before
fq_init() from ieee80211_txq_setup_flows() initializes this spinlock.

According to discussion [2], Toke was not happy with expanding usage of
fq.lock. Since __ieee80211_wake_txqs() is called under RCU read lock, we
can instead use synchronize_rcu() for flushing ieee80211_wake_txqs().

Link: https://syzkaller.appspot.com/bug?extid=eceab52db7c4b961e9d6 [1]
Link: https://lkml.kernel.org/r/874k0zowh2.fsf@toke.dk [2]
Reported-by: syzbot <syzbot+eceab52db7c4b961e9d6@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fixes: f856373e2f ("wifi: mac80211: do not wake queues on a vif that is being stopped")
Tested-by: syzbot <syzbot+eceab52db7c4b961e9d6@syzkaller.appspotmail.com>
Acked-by: Toke Høiland-Jørgensen <toke@kernel.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/9cc9b81d-75a3-3925-b612-9d0ad3cab82b@I-love.SAKURA.ne.jp
[ pick up commit 3598cb6e18 ("wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop()") from -next]
Link: https://lore.kernel.org/all/87o7xcq6qt.fsf@kernel.org/
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2022-07-26 13:23:05 -07:00
..
aead_api.c
…
aead_api.h
…
aes_ccm.h
…
aes_cmac.c
…
aes_cmac.h
…
aes_gcm.h
…
aes_gmac.c
…
aes_gmac.h
…
agg-rx.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
agg-tx.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
airtime.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
cfg.c
wifi: mac80211: add gfp_t parameter to ieeee80211_obss_color_collision_notify
2022-06-29 11:43:15 +02:00
chan.c
wifi: mac80211: fix use-after-free in chanctx code
2022-06-01 12:41:41 +03:00
debug.h
…
debugfs_key.c
mac80211: remove unused macros
2022-02-04 16:26:27 +01:00
debugfs_key.h
…
debugfs_netdev.c
mac80211: use ifmgd->bssid instead of ifmgd->associated->bssid
2022-05-16 09:13:22 +02:00
debugfs_netdev.h
…
debugfs_sta.c
Merge tag 'wireless-next-2022-05-03' of git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next
2022-05-03 17:27:51 -07:00
debugfs_sta.h
…
debugfs.c
mac80211: introduce BSS color collision detection
2022-04-11 15:24:15 +02:00
debugfs.h
…
driver-ops.c
…
driver-ops.h
…
eht.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
ethtool.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
fils_aead.c
…
fils_aead.h
…
he.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
ht.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
ibss.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
ieee80211_i.h
mac80211: mlme: track assoc_bss/associated separately
2022-05-16 09:16:20 +02:00
iface.c
wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop()
2022-07-26 13:23:05 -07:00
Kconfig
…
key.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
key.h
…
led.c
…
led.h
…
main.c
mac80211: remove unused argument to ieee80211_sta_connection_lost()
2022-05-16 09:15:04 +02:00
Makefile
mac80211: Handle station association response with EHT
2022-02-16 15:44:09 +01:00
mesh_hwmp.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
mesh_pathtbl.c
…
mesh_plink.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
mesh_ps.c
…
mesh_sync.c
…
mesh.c
mac80211: Use GFP_KERNEL instead of GFP_ATOMIC when possible
2022-03-11 11:42:49 +01:00
mesh.h
…
michael.c
…
michael.h
…
mlme.c
Merge tag 'wireless-next-2022-05-19' of git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next
2022-05-19 13:01:08 -07:00
ocb.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
offchannel.c
mac80211: use ifmgd->bssid instead of ifmgd->associated->bssid
2022-05-16 09:13:22 +02:00
pm.c
…
rate.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
rate.h
…
rc80211_minstrel_ht_debugfs.c
…
rc80211_minstrel_ht.c
mac80211: minstrel_ht: support ieee80211_rate_status
2022-05-16 10:07:58 +02:00
rc80211_minstrel_ht.h
mac80211: minstrel_ht: support ieee80211_rate_status
2022-05-16 10:07:58 +02:00
rx.c
wifi: mac80211: add gfp_t parameter to ieeee80211_obss_color_collision_notify
2022-06-29 11:43:15 +02:00
s1g.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
scan.c
mac80211: upgrade passive scan to active scan on DFS channels after beacon rx
2022-05-04 22:49:38 +02:00
spectmgmt.c
…
sta_info.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
sta_info.h
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
status.c
mac80211: extend current rate control tx status API
2022-05-16 10:05:02 +02:00
tdls.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
tkip.c
…
tkip.h
…
trace_msg.h
…
trace.c
…
trace.h
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
tx.c
wifi: mac80211: check skb_shared in ieee80211_8023_xmit()
2022-06-29 11:43:15 +02:00
util.c
wifi: mac80211: do not wake queues on a vif that is being stopped
2022-06-29 11:43:15 +02:00
vht.c
mac80211: prepare sta handling for MLO support
2022-04-11 16:42:03 +02:00
wep.c
…
wep.h
…
wme.c
wifi: mac80211: fix queue selection for mesh/OCB interfaces
2022-07-11 10:36:55 +02:00
wme.h
…
wpa.c
mac80211: unify CCMP/GCMP AAD construction
2022-05-16 09:10:38 +02:00
wpa.h
…