09ed061a4f
Now that the /firmware/coreboot node in DT is populated by the core DT platform code with commit3aa0582fdb("of: platform: populate /firmware/ node from of_platform_default_populate_init()") we should and can remove the platform device creation here. Otherwise, the of_platform_device_create() call will fail, the coreboot of driver won't be registered, and this driver will never bind. At the same time, we should move this driver to use MODULE_DEVICE_TABLE so that module auto-load works properly when the coreboot device is auto-populated and we should drop the of_node handling that was presumably placed here to hold a reference to the DT node created during module init that no longer happens. Cc: Wei-Ning Huang <wnhuang@chromium.org> Cc: Julius Werner <jwerner@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> Cc: Samuel Holland <samuel@sholland.org> Reviewed-by: Sudeep Holla <Sudeep.Holla@arm.com> Fixes:3aa0582fdb("of: platform: populate /firmware/ node from of_platform_default_populate_init()") Signed-off-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
61 lines
1.5 KiB
C
61 lines
1.5 KiB
C
/*
|
|
* coreboot_table-of.c
|
|
*
|
|
* Coreboot table access through open firmware.
|
|
*
|
|
* Copyright 2017 Google Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License v2.0 as published by
|
|
* the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/io.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include "coreboot_table.h"
|
|
|
|
static int coreboot_table_of_probe(struct platform_device *pdev)
|
|
{
|
|
struct device_node *fw_dn = pdev->dev.of_node;
|
|
void __iomem *ptr;
|
|
|
|
ptr = of_iomap(fw_dn, 0);
|
|
if (!ptr)
|
|
return -ENOMEM;
|
|
|
|
return coreboot_table_init(&pdev->dev, ptr);
|
|
}
|
|
|
|
static int coreboot_table_of_remove(struct platform_device *pdev)
|
|
{
|
|
return coreboot_table_exit();
|
|
}
|
|
|
|
static const struct of_device_id coreboot_of_match[] = {
|
|
{ .compatible = "coreboot" },
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(of, coreboot_of_match);
|
|
|
|
static struct platform_driver coreboot_table_of_driver = {
|
|
.probe = coreboot_table_of_probe,
|
|
.remove = coreboot_table_of_remove,
|
|
.driver = {
|
|
.name = "coreboot_table_of",
|
|
.of_match_table = coreboot_of_match,
|
|
},
|
|
};
|
|
module_platform_driver(coreboot_table_of_driver);
|
|
|
|
MODULE_AUTHOR("Google, Inc.");
|
|
MODULE_LICENSE("GPL");
|