Wang Nan 421fd0845e perf probe: Verify parameters in two functions ...

On kernel with only one out of CONFIG_KPROBE_EVENTS and
CONFIG_UPROBE_EVENTS enabled, 'perf probe -d' causes a segfault because
perf_del_probe_events() calls probe_file__get_events() with a negative
fd.

This patch fixes it by adding parameter validation at the entry of
probe_file__get_events() and probe_file__get_rawlist(). Since they are
both non-static public functions (in .h file), parameter verifying is
required.

v1 -> v2: Verify fd at the head of probe_file__get_rawlist() instead of
          checking at call site (suggested by Masami and Arnaldo at [1,2]).

[1] http://lkml.kernel.org/r/50399556C9727B4D88A595C8584AAB37526048E3@GSjpTKYDCembx32.service.hitachi.net
[2] http://lkml.kernel.org/r/20151105155830.GV13236@kernel.org

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1446803415-83382-1-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

2015-11-11 18:41:32 -03:00

..

arch

perf tests: Add Intel CQM test

2015-10-05 16:56:07 -03:00

bench

perf bench: Use named initializers in the trailer too

2015-10-19 18:17:25 -03:00

config

perf tools: Make perf depend on libbpf

2015-10-28 12:48:12 -03:00

Documentation

perf trace: Fix documentation for -i

2015-11-05 12:47:51 -03:00

python

perf python: Support the PERF_RECORD_SWITCH event

2015-10-07 19:41:50 -03:00

scripts

…

tests

perf test: Add llvm-src-base.c and llvm-src-kbuild.c to .gitignore

2015-11-11 18:41:23 -03:00

trace/strace/groups

…

ui

perf annotate: Don't die() when finding an invalid config option

2015-10-22 18:10:52 -03:00

util

perf probe: Verify parameters in two functions

2015-11-11 18:41:32 -03:00

.gitignore

…

Build

…

builtin-annotate.c

…

builtin-bench.c

perf bench: Run benchmarks, don't test them

2015-10-19 16:10:25 -03:00

builtin-buildid-cache.c

…

builtin-buildid-list.c

…

builtin-data.c

…

builtin-diff.c

…

builtin-evlist.c

perf tools: Introduce usage_with_options_msg()

2015-10-27 09:28:44 -03:00

builtin-help.c

perf help: Change 'usage' to 'Usage' for consistency

2015-10-19 16:51:44 -03:00

builtin-inject.c

perf inject: Add --strip option to strip out non-synthesized events

2015-09-28 17:19:51 -03:00

builtin-kmem.c

perf machine: Add method for common kernel_map(FUNCTION) operation

2015-09-30 18:34:29 -03:00

builtin-kvm.c

…

builtin-list.c

perf list: Do event name substring search as last resort when no events found

2015-10-01 12:12:22 -03:00

builtin-lock.c

…

builtin-mem.c

…

builtin-probe.c

perf tools: Introduce usage_with_options_msg()

2015-10-27 09:28:44 -03:00

builtin-record.c

perf record: Add clang options for compiling BPF scripts

2015-10-29 17:16:22 -03:00

builtin-report.c

perf report: Rename to --show-cpu-utilization

2015-10-26 14:06:04 -03:00

builtin-sched.c

perf sched latency: Fix thread pid reuse issue

2015-11-05 12:51:00 -03:00

builtin-script.c

perf script: Enable printing of branch stack

2015-10-29 17:16:20 -03:00

builtin-stat.c

perf stat: Make stat options global

2015-11-05 17:54:34 -03:00

builtin-timechart.c

…

builtin-top.c

perf tools: Improve call graph documents and help messages

2015-10-22 16:23:19 -03:00

builtin-trace.c

perf trace: Add cmd string table to decode sys_bpf first arg

2015-10-29 11:48:18 -03:00

builtin.h

…

command-list.txt

…

CREDITS

…

design.txt

…

Makefile

perf tools: Allow shuffling the build tests

2015-11-05 11:39:54 -03:00

Makefile.perf

perf tools: Make sure fixdep is built before libbpf

2015-10-29 17:16:21 -03:00

MANIFEST

perf tools: Make perf depend on libbpf

2015-10-28 12:48:12 -03:00

perf-archive.sh

…

perf-completion.sh

…

perf-read-vdso.c

…

perf-sys.h

…

perf-with-kcore.sh

…

perf.c

perf tools: Enable passing bpf object file to --event

2015-10-28 12:48:12 -03:00

perf.h

…