Thiago Rafael Becker bdcf0a423e kernel: make groups_sort calling a responsibility group_info allocators ...

In testing, we found that nfsd threads may call set_groups in parallel
for the same entry cached in auth.unix.gid, racing in the call of
groups_sort, corrupting the groups for that entry and leading to
permission denials for the client.

This patch:
 - Make groups_sort globally visible.
 - Move the call to groups_sort to the modifiers of group_info
 - Remove the call to groups_sort from set_groups

Link: http://lkml.kernel.org/r/20171211151420.18655-1-thiago.becker@gmail.com
Signed-off-by: Thiago Rafael Becker <thiago.becker@gmail.com>
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
Reviewed-by: NeilBrown <neilb@suse.com>
Acked-by: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2017-12-14 16:00:49 -08:00

..

acl.h

…

auth.c

kernel: make groups_sort calling a responsibility group_info allocators

2017-12-14 16:00:49 -08:00

auth.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

blocklayout.c

Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4

2017-11-14 12:59:42 -08:00

blocklayoutxdr.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

blocklayoutxdr.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

cache.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

current_stateid.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

export.c

NFSD: make cache_detail structures const

2017-11-27 16:45:11 -05:00

export.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

fault_inject.c

Merge tag 'nfsd-4.15' of git://linux-nfs.org/~bfields/linux

2017-11-18 11:22:04 -08:00

flexfilelayout.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

flexfilelayoutxdr.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

flexfilelayoutxdr.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

idmap.h

…

Kconfig

block: make scsi_request and scsi ioctl support optional

2017-01-31 10:53:05 -07:00

lockd.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

netns.h

race of nfsd inetaddr notifiers vs nn->nfsd_serv change

2017-11-27 16:45:11 -05:00

nfs2acl.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

nfs3acl.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

nfs3proc.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

nfs3xdr.c

Merge tag 'nfsd-4.15' of git://linux-nfs.org/~bfields/linux

2017-11-18 11:22:04 -08:00

nfs4acl.c

…

nfs4callback.c

nfsd: Fix a memory scribble in the callback channel

2017-07-17 13:15:06 -04:00

nfs4idmap.c

NFSD: make cache_detail structures const

2017-11-27 16:45:11 -05:00

nfs4layouts.c

Merge tag 'nfsd-4.15' of git://linux-nfs.org/~bfields/linux

2017-11-18 11:22:04 -08:00

nfs4proc.c

Merge tag 'nfsd-4.15' of git://linux-nfs.org/~bfields/linux

2017-11-18 11:22:04 -08:00

nfs4recover.c

…

nfs4state.c

lockd: fix "list_add double add" caused by legacy signal interface

2017-11-27 16:45:11 -05:00

nfs4xdr.c

nfsd: Incoming xdr_bufs may have content in tail buffer

2017-09-05 15:15:29 -04:00

nfscache.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

nfsctl.c

race of nfsd inetaddr notifiers vs nn->nfsd_serv change

2017-11-27 16:45:11 -05:00

nfsd.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

nfsfh.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

nfsfh.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

nfsproc.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

nfssvc.c

race of nfsd inetaddr notifiers vs nn->nfsd_serv change

2017-11-27 16:45:11 -05:00

nfsxdr.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

pnfs.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

state.h

fs, nfsd: convert nfs4_file.fi_ref from atomic_t to refcount_t

2017-11-07 16:43:59 -05:00

stats.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

stats.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

trace.c

…

trace.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

vfs.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

vfs.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

xdr3.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

xdr4.h

nfsd4: fix cached replies to solo SEQUENCE compounds

2017-11-07 16:43:57 -05:00

xdr4cb.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

xdr.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00