quota: Fix possible GPF due to uninitialised pointers
[ Upstream commit ab73ef46398e2c0159f3a71de834586422d2a44a ] When dqget() in __dquot_initialize() fails e.g. due to IO error, __dquot_initialize() will pass an array of uninitialized pointers to dqput_all() and thus can lead to deference of random data. Fix the problem by properly initializing the array. CC: stable@vger.kernel.org Signed-off-by: Nikolay Borisov <kernel@kyup.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
This commit is contained in:
committed by
Sasha Levin
parent
594103da30
commit
ab1cc52b3f
@ -1393,7 +1393,7 @@ static int dquot_active(const struct inode *inode)
|
||||
static void __dquot_initialize(struct inode *inode, int type)
|
||||
{
|
||||
int cnt, init_needed = 0;
|
||||
struct dquot **dquots, *got[MAXQUOTAS];
|
||||
struct dquot **dquots, *got[MAXQUOTAS] = {};
|
||||
struct super_block *sb = inode->i_sb;
|
||||
qsize_t rsv;
|
||||
|
||||
@ -1408,7 +1408,6 @@ static void __dquot_initialize(struct inode *inode, int type)
|
||||
kprojid_t projid;
|
||||
int rc;
|
||||
|
||||
got[cnt] = NULL;
|
||||
if (type != -1 && cnt != type)
|
||||
continue;
|
||||
/*
|
||||
|
||||
Reference in New Issue
Block a user