md: Avoid write invalid address if read_seqretry returned true.
commit 35f9ac2dce upstream.
If read_seqretry returned true and bbp was changed, it will write
invalid address which can cause some serious problem.
This bug was introduced by commit v3.0-rc7-130-g2699b67.
So fix is suitable for 3.0.y thru 3.6.y.
Reported-by: zhuwenfeng@kedacom.com
Tested-by: zhuwenfeng@kedacom.com
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
This commit is contained in:
committed by
Ben Hutchings
parent
e76f340714
commit
a97aecfa37
@ -1801,10 +1801,10 @@ retry:
|
||||
memset(bbp, 0xff, PAGE_SIZE);
|
||||
|
||||
for (i = 0 ; i < bb->count ; i++) {
|
||||
u64 internal_bb = *p++;
|
||||
u64 internal_bb = p[i];
|
||||
u64 store_bb = ((BB_OFFSET(internal_bb) << 10)
|
||||
| BB_LEN(internal_bb));
|
||||
*bbp++ = cpu_to_le64(store_bb);
|
||||
bbp[i] = cpu_to_le64(store_bb);
|
||||
}
|
||||
bb->changed = 0;
|
||||
if (read_seqretry(&bb->lock, seq))
|
||||
|
||||
Reference in New Issue
Block a user